Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rhel9 power ABS name #350

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix rhel9 power ABS name #350

merged 1 commit into from
Jan 24, 2024

Conversation

nmburgan
Copy link
Contributor

On behalf of @trvs-sdlr

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (184d0c5) 0.72% compared to head (4ce9542) 0.72%.

Files Patch % Lines
lib/beaker-hostgenerator/data.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #350   +/-   ##
======================================
  Coverage    0.72%   0.72%           
======================================
  Files          15      15           
  Lines        1801    1801           
======================================
  Hits           13      13           
  Misses       1788    1788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nmburgan
Copy link
Contributor Author

I assume the codecov thing is not such a big deal since the previous line didn't have coverage either.

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the codecov thing is not such a big deal since the previous line didn't have coverage either.

I honestly don't care about code coverage at all in general, but in this particular case it can't measure the coverage by integration tests either so it's really misleading. Like in this case, it's often misleading. With 100% coverage you can easily have bugs in the integration.

@ekohl ekohl merged commit fc90bf1 into voxpupuli:master Jan 24, 2024
7 of 8 checks passed
@ekohl ekohl added the bug label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants