From 46756f2a98ea7a876cc0981ebc0ea04d28209f2a Mon Sep 17 00:00:00 2001 From: Robert Waffen Date: Thu, 24 Oct 2024 09:55:06 +0200 Subject: [PATCH 1/3] feat: add shellcheck --- .github/workflows/ci.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index dafcc4a..a90b352 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,6 +8,11 @@ on: workflow_dispatch: jobs: + general_ci: + uses: voxpupuli/crafty/.github/workflows/general_ci.yaml@main + with: + shellcheck_scan_dir: '.' + build_test_container: name: 'Build test container' runs-on: ubuntu-latest From 3de9279033bee9f090a8c98b86894db031f38d63 Mon Sep 17 00:00:00 2001 From: Robert Waffen Date: Thu, 24 Oct 2024 10:03:02 +0200 Subject: [PATCH 2/3] feat: use Differential ShellCheck directly --- .github/workflows/ci.yaml | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index a90b352..6042c52 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,10 +8,21 @@ on: workflow_dispatch: jobs: - general_ci: - uses: voxpupuli/crafty/.github/workflows/general_ci.yaml@main - with: - shellcheck_scan_dir: '.' + shellcheck: + name: 'Shell Check' + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + + - name: Differential ShellCheck + uses: redhat-plumbers-in-action/differential-shellcheck@v5 + with: + scan-directory: | + ./docker-entrypoint.d/ + ./scripts/ + token: ${{ secrets.GITHUB_TOKEN }} + + build_test_container: name: 'Build test container' From 8fac529b10cff9b9c78a502dc029b913e6cd5ad6 Mon Sep 17 00:00:00 2001 From: Robert Waffen Date: Thu, 24 Oct 2024 17:00:56 +0200 Subject: [PATCH 3/3] revert: change back to shared workflow --- .github/workflows/ci.yaml | 19 ++++--------------- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 6042c52..a90b352 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -8,21 +8,10 @@ on: workflow_dispatch: jobs: - shellcheck: - name: 'Shell Check' - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - - name: Differential ShellCheck - uses: redhat-plumbers-in-action/differential-shellcheck@v5 - with: - scan-directory: | - ./docker-entrypoint.d/ - ./scripts/ - token: ${{ secrets.GITHUB_TOKEN }} - - + general_ci: + uses: voxpupuli/crafty/.github/workflows/general_ci.yaml@main + with: + shellcheck_scan_dir: '.' build_test_container: name: 'Build test container'