GHA: Replace BEAKER_setfile->BEAKER_SETFILE env var #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
requested changes
Sep 20, 2023
|
would this be a good point to create a V2 branch maybe? |
|
Maybe, but I'm hesitant. What's the value of doing this now? beaker-rspec hasn't stopped reading both. Having a longer transition window means we don't need to maintain two branches. |
ekohl
requested changes
Oct 7, 2023
There was a problem hiding this comment.
This, together with raising the Ruby version for acceptance tests to 3.2 and depending on voxpupuli/puppet_metadata#35 would make a good v2 for gha-puppet. If you agree, I think we should create that branch and change the base branch on this PR.
|
@ekohl yes that sounds awesome. Feel free to do it if you like, otherwise I can zake a look on monday or tuesday. |
|
@ekohl this now merges into the the new v2 branch. |
|
@ekohl updated it. |
ekohl
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.