Add support for downloading *_core modules #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garrettrowell
force-pushed
the
vendored_modules
branch
from
bf0d0ed to
b5b7d46
Compare
garrettrowell
force-pushed
the
vendored_modules
branch
from
f7004e5 to
f38e136
Compare
bastelfreak
reviewed
Nov 14, 2024
bastelfreak
changed the title
bastelfreak
reviewed
Nov 14, 2024
spec/fixtures/controlrepos/vendored/spec/vendored_modules/augeas_core-puppet_agent-7.30.0.json
Show resolved
Hide resolved
bastelfreak
force-pushed
the
vendored_modules
branch
from
48d6f71 to
4f0d708
Compare
bastelfreak
force-pushed
the
vendored_modules
branch
from
4f0d708 to
c44f64b
Compare
|
mhm I'm not sure why rubocop is unhappy 🤔 |
bastelfreak
force-pushed
the
vendored_modules
branch
from
77d92c1 to
a78af97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When beginning to spec test a common issue people run into is
Unknown resource type: <xyz>, where xyz is provided by a module vendored into the puppet-agent. The typical fix for this is adding said vendored module(s) into the Puppetfile and .fixtures.yml. See: #291This PR aims to alleviate some of that pain by determining the vendored modules and their versions for the version of the puppet-agent being tested with, and adding them to the Puppetfile that onceover deploys in its working directory assuming the vendored module already isn't being managed.