Change to fix issue 144, check for presence of specifed ca_file (#1)

REFERENCE.md

@@ -294,6 +294,7 @@ It can be used when the certificate of the gitlab server is signed using a CA
 and when upon registering a runner the following error is shown:
 `certificate verify failed (self signed certificate in certificate chain)`
 Using the CA file solves https://github.com/voxpupuli/puppet-gitlab_ci_runner/issues/124.
+The ca_file must exist, if it does not. Gitlab runner token generation will be skipped. Gitlab runner will not register until either the file exists or the ca_file parameter is not specified.
 
 Default value: ``undef``
 

lib/puppet/functions/gitlab_ci_runner/register_to_file.rb

@@ -41,6 +41,11 @@ def register_to_file(url, regtoken, runner_name, additional_options = {}, proxy
       return 'DUMMY-NOOP-TOKEN' if Puppet.settings[:noop]
 
       begin
+        # Confirm the specified ca file exists
+        if !ca_file.nil? && !File.exist?(ca_file)
+          puts('Specified CA file doesn\'t exist for gitlab-ci-runner. Did you forget to create it?')
+          return 'Specified CA file doesn\'t exist, not creating authtoken'
+        end
         authtoken = PuppetX::Gitlab::Runner.register(url, additional_options.merge('token' => regtoken), proxy, ca_file)['token']
 
         # If this function is used as a Deferred function the Gitlab Runner config dir

manifests/init.pp

@@ -72,6 +72,7 @@
 #   and when upon registering a runner the following error is shown:
 #   `certificate verify failed (self signed certificate in certificate chain)`
 #   Using the CA file solves https://github.com/voxpupuli/puppet-gitlab_ci_runner/issues/124.
+#   The ca_file must exist, if it does not. Gitlab runner token generation will be skipped. Gitlab runner will not register until either the file exists or the ca_file parameter is not specified.
 #
 class gitlab_ci_runner (
   String                                     $xz_package_name, # Defaults in module hieradata

spec/functions/register_to_file_spec.rb

@@ -44,12 +44,20 @@
 
     it { is_expected.to run.with_params(url, regtoken, runner_name).and_return(return_hash['token']) }
 
-    context 'with ca_file option' do
+    context 'with existing file ca_file option' do
+      before do
+        allow(PuppetX::Gitlab::Runner).to receive(:register).with(url, { 'token' => regtoken }, nil, '/tmp').and_return(return_hash)
+      end
+
+      it { is_expected.to run.with_params(url, regtoken, runner_name, {}, nil, '/tmp').and_return(return_hash['token']) }
+    end
+
+    context 'with non existent ca_file option' do
       before do
         allow(PuppetX::Gitlab::Runner).to receive(:register).with(url, { 'token' => regtoken }, nil, '/path/to/ca_file').and_return(return_hash)
       end
 
-      it { is_expected.to run.with_params(url, regtoken, runner_name, {}, nil, '/path/to/ca_file').and_return(return_hash['token']) }
+      it { is_expected.to run.with_params(url, regtoken, runner_name, {}, nil, '/path/to/ca_file').and_return('Specified CA file doesn\'t exist, not creating authtoken') }
     end
   end