Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debian Docker: Configure correct shell for hdm user #20

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Conversation

bastelfreak
Copy link
Member

This is cherry-picked from #19. The shell for the hdm user on Debian is different compared to RedHat. This commit fixes it. I verified it locally and it now works fine on Debian. The acceptance tests in #19 currently don't pass because the docker in docker in GHA setup doesn't work correctly.

@bastelfreak bastelfreak added the bug Something isn't working label Nov 23, 2022
@bastelfreak bastelfreak requested a review from rwaffen November 23, 2022 07:57
@bastelfreak bastelfreak self-assigned this Nov 23, 2022
@bastelfreak bastelfreak changed the title Debian: Configure correct shell for hdm user Debian Docker: Configure correct shell for hdm user Nov 23, 2022
Copy link
Member

@rwaffen rwaffen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you be so nice and also add this to the rvm class? :)

@bastelfreak
Copy link
Member Author

There are a few more things broken for the RVM setup, I will fix that in another PR.

@bastelfreak bastelfreak merged commit 8ac4493 into main Nov 23, 2022
@bastelfreak bastelfreak deleted the debian2 branch November 23, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants