Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix acceptance test Java version #1093

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix acceptance test Java version #1093

wants to merge 4 commits into from

Conversation

zilchms
Copy link
Contributor

@zilchms zilchms commented Mar 27, 2024

includes: #1092

@zilchms
Copy link
Contributor Author

zilchms commented Mar 28, 2024

Ahhhh, now I understand. The acceptance tests have never worked in the first place. Well time to fix that then (or write new tests)

@Valantin
Copy link

If is usefull I use this to install java 21 on my test jenkis setup on a ubuntu 22.04

java::package: openjdk-21-jdk
java::alternative: java-1.21.0-openjdk-amd64
java::alternative_path: /usr/lib/jvm/java-1.21.0-openjdk-amd64/bin/java
java::java_home: /usr/lib/jvm/java-1.21.0-openjdk-amd64/

I haven't checked if everything is necessary

evgeni
evgeni reviewed Apr 24, 2024
View reviewed changes
spec/acceptance/hieradata/common.yaml
@@ -1,3 +1,3 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rename seems wrong, the package name is not common but specific to the RedHat family

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say that https://github.com/voxpupuli/voxpupuli-acceptance/?tab=readme-ov-file#hiera shows the default hierachy, but this module still uses the old voxpupuli-acceptance 2.x where os really is family. See voxpupuli/voxpupuli-acceptance@650b642

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does not since yesterday :)

evgeni
evgeni reviewed Apr 24, 2024
View reviewed changes
spec/acceptance/hieradata/os/Debian.yaml
Comment on lines +2 to +3
# Jenkins 2.361.1 requires Java 11 or newer
java::package: openjdk-17-jdk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you say 11, but use 17? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@evgeni evgeni evgeni left review comments

@bastelfreak bastelfreak bastelfreak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zilchms @Valantin @evgeni @ekohl @bastelfreak