Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer and producer classes needed? #381

Open
schustersv opened this issue Dec 17, 2024 · 0 comments
Open

consumer and producer classes needed? #381

schustersv opened this issue Dec 17, 2024 · 0 comments

Comments

@schustersv
Copy link
Contributor

schustersv commented Dec 17, 2024

Hello,
I'm currently working on some overhaul of puppet-kafka (bring puppet-systemd usage up to date, improve testing, get rid of erb templates) and have made quite some progress in updating puppet-systemd usage for the kafka::broker class.

Before putting some more effort into the other classes, I'd like to raise the question whether the consumer and producer classes are useful and really needed at all. Those classes set up systemd units starting cli tools contained in the Kafka package/tarball. The cli tools are meant as examples, for testing and debugging imho though. Therefore, I doubt these classes are really useful at all. Of course just that we don't use it in our environment doesn't mean noone uses them, still I think this should be discussed.
Even the mirror class is questionable as Kafka Mirrormaker has progressed a lot since the original implementation. But then, at least there's some usefulness in this so it makes more sense to keep them.

If we agree on that, I'll prepare the necessary changes to get rid of those classes.

Thanks for your opinions!

Best regards
Sven

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant