Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support sensitive and deferred values where passwords are used #214

Open
llowder opened this issue Apr 24, 2020 · 1 comment
Open

Support sensitive and deferred values where passwords are used #214

llowder opened this issue Apr 24, 2020 · 1 comment
Labels

Comments

@llowder
Copy link
Contributor

llowder commented Apr 24, 2020

This is dependent on #213

With the introduction of the Deferred type and Sensitive, more people are wanting to use these to be able to secure potentially sensitive data.

However, it is not easy to just mark one piece of data as deferred, then use it in a forge / third party module, since a typed parameter will reject getting a deferred type instead.

I would propose that all parameters that could be reasonably considered sensitive have their typing adjusted to allow for either the current type, or something that was deferred.

The main places would be $keepalived::vrrp::instance::auth_pass , the related $keepalived::vrrp_instance hash, and the templates, such as the vrrp_instance one.

This can be done in a mostly backwards compatible way... but I believe the templates have to be epp to be properly deferred, which makes it breaking unless both are maintained for a while and flag selectable.

@luitzifa
Copy link

i don't quite get the backwards-incompatible label on this and the mentioned #213 issue. epp is available since puppet 4 and "sensitive" is available since puppet 5.
This module just dropped support for puppet <6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants