Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needed to add vmac support #91

Open
stevedwray opened this issue Feb 12, 2016 · 2 comments
Open

Needed to add vmac support #91

stevedwray opened this issue Feb 12, 2016 · 2 comments

Comments

@stevedwray
Copy link

Hi, I needed to add vmac support so I made the following patch I hope you can integrate this for the future:

diff -ru /etc/puppet/environments/development/modules/keepalived/manifests/vrrp/instance.pp arioch-keepalived-1.2.3/manifests/vrrp/instance.pp
--- /etc/puppet/environments/development/modules/keepalived/manifests/vrrp/instance.pp  2016-02-12 18:17:03.405480812 +0000
+++ arioch-keepalived-1.2.3/manifests/vrrp/instance.pp  2015-11-06 08:42:18.000000000 +0000
@@ -164,8 +164,6 @@
   $unicast_source_ip          = undef,
   $unicast_peers              = undef,
   $dont_track_primary         = false,
-  $use_vmac                   = false,
-  $vmac_xmit_base             = false,

 ) {
   $_name = regsubst($name, '[:\/\n]', '')
diff -ru /etc/puppet/environments/development/modules/keepalived/templates/vrrp_instance.erb arioch-keepalived-1.2.3/templates/vrrp_instance.erb
--- /etc/puppet/environments/development/modules/keepalived/templates/vrrp_instance.erb 2016-02-12 18:18:48.851261492 +0000
+++ arioch-keepalived-1.2.3/templates/vrrp_instance.erb 2015-08-04 14:26:22.000000000 +0000
@@ -5,15 +5,6 @@
   priority                  <%= @priority %>
   advert_int                <%= @advert_int %>
   garp_master_delay         <%= @garp_master_delay %>
-
-  <%- if @use_vmac -%>
-  use_vmac
-  <%- end -%>
-
-  <%- if @vmac_xmit_base -%>
-  vmac_xmit_base
-  <%- end -%>
-
   <%- if @lvs_interface -%>
   lvs_sync_daemon_interface <%= @lvs_interface %>
   <%- end -%>

@arioch
Copy link
Contributor

arioch commented Feb 15, 2016

Hi @stevedwray

Could you wrap this in a pull request?
I'd prefer you to have the proper credits for this patch instead of my name showing up instead.

If you're unsure how to create a pull request don't hesitate to ask, I'll help you through the process.

@saz
Copy link
Contributor

saz commented Sep 25, 2019

Support has been added with the merge of #108
This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants