Fix readonly database property #422
Conversation
|
Squashed and rebased as requested @smortex. Not convinced the spec tests work correctly though. |
There was a problem hiding this comment.
Not convinced the spec tests work correctly though.
Tests are run by GitHub and show what is found vs what was expected. CI failed at an earlier stage but fixing the issue above bellow should allow it to continue. In any case, if you want to run these tests on your machine you can:
bundle exec rake spec_prep
bundle exec rspec spec/unit/puppet/provider/openldap_database/olc_spec.rb
| @@ -167,6 +167,8 @@ def should_to_s(_newvalue) | |||
|
|
|||
| newproperty(:readonly) do | |||
| desc 'Puts the database into read-only mode.' | |||
| newvalues(:true, :false) | |||
| defaultto(:false) | |||
There was a problem hiding this comment.
I guess the new default value is the reason for the CI failue:
REFERENCE.md is outdated
Please update REFERENCE.md with
$ bundle exec rake strings:generate:referenceAdd it to the PR and CI should continue.
The database `readonly` property expects a boolean, but the olc provider doesn't take care to parse the existing value into a boolean, thus leading to issues. Simply applies the same logic applied to `olcMirrorMode` for `olcReadOnly`.
|
This is failing on the tests. I'm not 100% sure exactly what the original author intended, and I don't have enough knowledge of RSpec to fix it I'm afraid. |
The database
readonlyproperty expects a boolean, but the olc provider doesn't take care to parse the existing value into a boolean, thus leading to issues.Simply applies the same logic applied to
olcMirrorModeforolcReadOnly.Fixes #207
Fixes #358