-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use source
in gemlist
#129
Conversation
When `ensure => latest`, `gemlist` is called to determine the latest available version of a gem. If the `source` parameter is a remote gem repository, this needs to be part of the `gem list` command run. Fixes voxpupuli#128 Signed-off-by: Alexander Fisher <[email protected]>
b4630db
to
8bbe0cf
Compare
@carlossg Hi. Does this look reasonable? Thanks. |
Dear @alexjfisher, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
2 similar comments
Dear @alexjfisher, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
Dear @alexjfisher, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
@alexjfisher any plans to rebase this? |
No plans. Don't think I've used the module since 2016, so can't remember what this was all about and if it's still relevant. |
Shall we close it then? |
Dunno. It looks correct, and someone might want it some day. I'm not in a position to verify it still works. I could rebase it anyway? |
Closing for now. If anyone's interested they can reopen it. |
When
ensure => latest
,gemlist
is called to determine the latestavailable version of a gem.
If the
source
parameter is a remote gem repository, this needs to bepart of the
gem list
command run.Fixes #128