The package resource name is hardcoded in one place.

[sirinek]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: all
• Ruby: all
• Distribution: RedHat
• Module version: 3.0.0

How to reproduce (e.g Puppet code you use)

Set $vault::package_name to something other than "vault"
Set $vault::install_method to "repo"
Set $vault::disable_mlock to false

What are you seeing

The puppet run fails because no Package resource named "vault" exists.

What behaviour did you expect instead

Expected the puppet run to succeed. The resource reference on line 61 of install.pp should not be hardcoded as Package['vault']
The package we use is called 'vault-enterprise' and we get it from an internal yum repo.

Output log

Info: Using environment 'bsirinek_vault'
Info: Retrieving pluginfacts
Info: Retrieving plugin
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/functions/vault_lookup]/ensure: created
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/functions/vault_lookup/lookup.rb]/ensure: defined content as '{md5}32cc63e233edeede24cf1231aef5577c'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/provider/file_capability]/ensure: created
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/provider/file_capability/linux.rb]/ensure: defined content as '{md5}a915eb75b975e2b977ebbf03a7fa1ad7'
Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/type/file_capability.rb]/ensure: defined content as '{md5}97ceed860b6e39bd67d15904e42c8429'
Info: Retrieving locales
Info: Loading facts
Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Could not find resource 'Package[vault]' for relationship on 'File_capability[vault_binary_capability]' on node agenthost.company.com
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run
root@agenthost #

Any additional information you'd like to impart

I have already submited a PR for this issue. #27