Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing rule with program set fails #117

Open
ghost opened this issue Jul 16, 2021 · 0 comments
Open

Removing rule with program set fails #117

ghost opened this issue Jul 16, 2021 · 0 comments

Comments

@ghost
Copy link

ghost commented Jul 16, 2021

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 6.21.1
  • Ruby: 2.5.8p224
  • Distribution: Windows
  • Module version: 4.0.0

How to reproduce (e.g Puppet code you use)

Set windows exception for absent when a program is set (for a rule that was previously created with puppet)

What are you seeing

Windows complains about the command used to remove the FW rule stating that "action" is not valid for the command.

What behaviour did you expect instead

FW rule should be removed

Output log

Any additional information you'd like to impart

The issue seems to be here https://github.com/voxpupuli/puppet-windows_firewall/blob/master/manifests/exception.pp#L156
Removing the and $program == undef resolves the issue, but I'm not sure why that was added in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants