Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High security vulnerabilities in versions 1.0.1 to 2.29.3 #48

Open
richbirch opened this issue Nov 3, 2022 · 3 comments
Open

High security vulnerabilities in versions 1.0.1 to 2.29.3 #48

richbirch opened this issue Nov 3, 2022 · 3 comments

Comments

@richbirch
Copy link
Contributor

The latest version of scala-js-momentjs uses momentjs 2.22.2, which suffers from the following two vulnerabilities:

These are scored as high. As such an upgrade to a version of at least 2.29.4 is required urgently

@richbirch
Copy link
Contributor Author

I have a fix for this issue. I don't have permission to create a branch to submit a PR from though..

build.sbt:

val MomentVersion = ">=2.29.4"
val MomentTimezoneVersion = "0.5.35"
val ScalaTestVersion = "3.2.13"

lazy val npmDeps = Seq(
  "moment" -> MomentVersion,
  "moment-timezone" -> MomentTimezoneVersion,
)

@vpavkin
Copy link
Owner

vpavkin commented Nov 3, 2022

@richbirch thank you. you can always fork and send a PR from your fork. This is the default workflow scala OSS projects usually have

@richbirch
Copy link
Contributor Author

Thank you for educating me :) Pull request submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants