Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TODO in is_separable check #621

Open
purva-thakre opened this issue Jun 6, 2024 · 0 comments
Open

TODO in is_separable check #621

purva-thakre opened this issue Jun 6, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@purva-thakre
Copy link
Collaborator

if (
state_rank + np.linalg.matrix_rank(pt_state_alice)
<= 2 * state.shape[0] * state.shape[1] - state.shape[0] - state.shape[1] + 2
or state_rank + np.linalg.matrix_rank(pt_state_bob)
<= 2 * state.shape[0] * state.shape[1] - state.shape[0] - state.shape[1] + 2
):
# Determined to be separable via operational criterion of the PPT criterion for low-rank operators.
# P. Horodecki, M. Lewenstein, G. Vidal, and I. Cirac.
# Operational criterion and constructive checks for the separability of low-rank density matrices.
# Phys. Rev. A, 62:032310, 2000.
# TODO
pass

Related to #518

@purva-thakre purva-thakre added enhancement New feature or request good first issue Good for newcomers labels Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant