Skip to content

Commit

Permalink
Release v0.24.0
Browse files Browse the repository at this point in the history
  • Loading branch information
@jsdevel
jsdevel committed Apr 6, 2018
1 parent 414c225 commit d6d22c9
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
19 changes: 19 additions & 0 deletions History.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,22 @@
0.24.0 / 2018-04-05
===================
* [DOC] Error on custom deserializer example (#1000)
* [DOC] Fix broken link
* [DOC] adding bullets to separate each option
* [DOC] changed ClientSSLSecurity to ClientSSLSecurityPFX in the readme file
* [DOC] clarify section on client events in Readme.md (#989)
* [ENHANCEMENT] Added one-way response configuration options
* [ENHANCEMENT] Adding support for SOAP 1.2 Envelope Headers in the server side (#1003)
* [ENHANCEMENT] Enable multiArgs during promisification
* [ENHANCEMENT] add Client.wsdl for accessing client.wsdl during soap.createClient() (#990)
* [ENHANCEMENT] add option to remove element-by-element namespacing of json arrays (#994)
* [ENHANCEMENT] add rawRequest to callback arguments (#992)
* [FIX] Fixed checking for empty obj.Body before further actions (#986)
* [FIX] Lookup definitions in child element first (#958)
* [FIX] only detect xsi:nil if its value is `true` (#983)
* [MAINTENANCE] Updating the coverage to use the new version of Istanbul framework, the nyc.
* [MAINTENANCE] Upgrade Lodash to 4.17.5 (#1001)

0.23.0 / 2017-10-18
===================
* [FIX] Fixing tests broken by #979
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "soap",
"version": "0.23.0",
"version": "0.24.0",
"description": "A minimal node SOAP client",
"engines": {
"node": ">=4.0.0"
Expand Down

6 comments on commit d6d22c9

@qwelias
Copy link

@qwelias qwelias commented on d6d22c9 Jul 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have no issues section opened I'll comment here.

@jsdevel
This is a minor release, but [ENHANCEMENT] Enable multiArgs during promisification is not an enhancement, it's a breaking change as the format of the resolved value had changed!

@jsdevel
Copy link
Collaborator Author

@jsdevel jsdevel commented on d6d22c9 Jul 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwelias i appreciate the concern. None of the existing tests needed to be changed (afaik). We usually strive to maintain back compat. Are you seeing an issue on your end?

@qwelias
Copy link

@qwelias qwelias commented on d6d22c9 Jul 7, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsdevel

@0.23.0

client.myFunctionAsync(args).then((result) => {})

@0.24.0

client.myFunctionAsync(args).then(([result, rawResponse, soapHeader, rawRequest]) => {})

EDIT:
Even the docs say the format has been altered and therefore is not compatible
https://i.imgur.com/OZqmW5V.png

@jsdevel
Copy link
Collaborator Author

@jsdevel jsdevel commented on d6d22c9 Jul 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qwelias i believe this is the PR hat introduced this: #988 Can you pick this up there? What would your suggested approach be? We definitely shouldn't break semver. If anything, we can change it to make it backwards compatible and do a patch release.

@herom
Copy link
Contributor

@herom herom commented on d6d22c9 Jul 9, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsdevel @qwelias In my opinion, we didn't break "semver" at all, even if it was a breaking change, because according to Semver-Spec #4 everyting which is released under major version 0, is "initial development".

That said, I'd vote for this module to release it's version 1.0.0 as it fulfills all requirements to be treated as such.

@qwelias
Copy link

@qwelias qwelias commented on d6d22c9 Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@herom good point, I didn't even knew about initial development being specified as 0.x.x

Please sign in to comment.