Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiled Windows version is missing from releases #74

Open
sanderdatema opened this issue Jun 20, 2021 · 6 comments
Open

Compiled Windows version is missing from releases #74

sanderdatema opened this issue Jun 20, 2021 · 6 comments

Comments

@sanderdatema
Copy link

The readme mentions Linux and Windows versions are in the releases. But it's only Linux. Since it's possible to compile for those two systems using Docker, you could have Github Actions do it for you. I know you're looking for developers, but I'm afraid I can't help out with this, though I'll try to look into it.

@vranki
Copy link
Owner

vranki commented Jun 21, 2021

Yeah, the windows cross-complilation seems to be broken at the moment for some reason. Needs to be studied. Help is welcome as I don't run X-Plane or develop on Windows.

@jfjoubert
Copy link

DISCLAIMER: I know very little about QT and Docker and cross-compilation etc... but I found that the Windows xpl was missing due to the DESTDIR = $$PWD line that was commented out in the extplane-server.pro file. I think this resulted in the libextplane-server.a file not being built or something. (like I said I know very little about this stuff :-))
I uncommented the line above and did a build using Docker on Windows and the final build contained both the win.xpl and lin.xpl files.
I tested the win.xpl in x-plane and everything seems to be working fine. Unfortunately, I cannot test the lin.xpl from this build as I don't have a Linux setup with x-plane.
Just thought it might be helpful to someone.

@sanderdatema
Copy link
Author

I uncommented the line above and did a build using Docker on Windows and the final build contained both the win.xpl and lin.xpl files.

Would you be able to create a PR for that?

@jfjoubert
Copy link

I have never done anything like that before, but I can give it a try.

@sanderdatema
Copy link
Author

sanderdatema commented Aug 25, 2021 via email

jfjoubert added a commit to jfjoubert/ExtPlane that referenced this issue Aug 25, 2021
This should fix the missing win.xpl and extplane-transformer.exe in the final build.
Relates to vranki#74
@tannerblair
Copy link

Any updates on this? I would love to use this, but I'm less fond of signing up for an account just so I can compile it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants