Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{bio}[GCCcore/13.2.0] EMMAX v20120210 w/ intel binary #21997

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pavelToman
Copy link
Collaborator

@pavelToman pavelToman commented Dec 10, 2024

(created using eb --new-pr)
resolves vscentrum/vsc-software-stack#470

Copy link

Updated software EMMAX-20120210-GCCcore-13.2.0-intel-binary.eb

Diff against EMMAX-20100310-foss-2023a.eb

easybuild/easyconfigs/e/EMMAX/EMMAX-20100310-foss-2023a.eb

diff --git a/easybuild/easyconfigs/e/EMMAX/EMMAX-20100310-foss-2023a.eb b/easybuild/easyconfigs/e/EMMAX/EMMAX-20120210-GCCcore-13.2.0-intel-binary.eb
index c68628823f..9d7150c71b 100644
--- a/easybuild/easyconfigs/e/EMMAX/EMMAX-20100310-foss-2023a.eb
+++ b/easybuild/easyconfigs/e/EMMAX/EMMAX-20120210-GCCcore-13.2.0-intel-binary.eb
@@ -1,40 +1,39 @@
-easyblock = 'MakeCp'
+easyblock = 'Binary'
 
 name = 'EMMAX'
-# version is based on datestamp of files in emmax-beta-src.tar.gz
-# (last checked on 13 Aug 2024)
-version = '20100310'
 
-homepage = 'https://csg.sph.umich.edu//kang/emmax'
+version = '20120210'
+versionsuffix = '-intel-binary'
+
+homepage = 'https://csg.sph.umich.edu/kang/emmax'
 description = """EMMAX is a statistical test for large scale human or model organism
   association mapping accounting for the sample structure"""
 
-toolchain = {'name': 'foss', 'version': '2023a'}
+toolchain = {'name': 'GCCcore', 'version': '13.2.0'}
 
 source_urls = ['https://csg.sph.umich.edu//kang/emmax/download/']
-sources = [{'download_filename': 'emmax-beta-src.tar.gz', 'filename': SOURCE_TAR_GZ}]
-patches = ['EMMAX-20100310_fix-build.patch']
-checksums = [
-    {'EMMAX-20100310.tar.gz': '79670917a0ac74ff1899fb27361e2e07b0f3a7911a9d9c6e0c18cf066b8987ea'},
-    {'EMMAX-20100310_fix-build.patch': 'fae62d1f9f7bd4b94c81cdeb01d5134cc2825bcab050ddbfa89ce232eca8497e'},
+sources = [
+    {
+        'download_filename': f'{name.lower()}{versionsuffix}-{version}.tar.gz',
+        'filename': f'{name}-{version}{versionsuffix}.tar.gz'
+    }
 ]
+checksums = ['e2a582851ba1be908757d4ef436e98ad76664a0c55e00d13e55fa35fe2ba54dd']
 
 dependencies = [
     ('zlib', '1.2.13'),
 ]
 
-buildopts = 'CC="$CC $CFLAGS" CLIBS="-lflexiblas -lm -lz"'
-
-files_to_copy = [(['emmax', 'emmax-kin'], 'bin')]
+extract_sources = True
 
 sanity_check_paths = {
-    'files': ['bin/emmax', 'bin/emmax-kin'],
+    'files': ['emmax-intel64', 'emmax-kin-intel64'],
     'dirs': [],
 }
 
 sanity_check_commands = [
-    "emmax 2>&1 | grep '^Usage: emmax'",
-    "emmax-kin 2>&1 | grep '^Usage: emmax_IBS_kin'",
+    "emmax-intel64 2>&1 | grep '^Usage: emmax'",
+    "emmax-kin-intel64 2>&1 | grep '^Usage: emmax_kin'",
 ]
 
 moduleclass = 'bio'

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on login1

PR test command 'EB_PR=21997 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21997 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14848

Test results coming soon (I hope)...

- notification for comment with ID 2531586994 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/d69bc3981649be65bcc28e36f61ca73b for a full test report.

@pavelToman
Copy link
Collaborator Author

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@pavelToman: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21997 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21997 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5425

Test results coming soon (I hope)...

- notification for comment with ID 2531676553 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.5, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.19
See https://gist.github.com/boegelbot/76306c0f7f4555173a4c1e44123d245e for a full test report.

@pavelToman
Copy link
Collaborator Author

Test report by @pavelToman
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4009.donphan.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6240 CPU @ 2.60GHz, 1 x NVIDIA NVIDIA A2, 545.23.08, Python 3.6.8
See https://gist.github.com/pavelToman/1e1e471cf34747271d406331985a8d71 for a full test report.

@pavelToman
Copy link
Collaborator Author

Test report by @pavelToman
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in total)
node4237.shinx.os - Linux RHEL 9.4, x86_64, AMD EPYC 9654 96-Core Processor, Python 3.9.18
See https://gist.github.com/pavelToman/8f12f45b9aaf0b0af2af804728319661 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

emmax-intel-binary-20120210
2 participants