Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Are we using signed or unsigned LEB128? #9

Closed
JobLeonard opened this issue Jul 28, 2022 · 2 comments
Closed

Are we using signed or unsigned LEB128? #9

JobLeonard opened this issue Jul 28, 2022 · 2 comments
Labels
planned question

Comments

@JobLeonard
Copy link

If I read the Python code correctly, the LEB128 lengths in strings and typed arrays are unsigned LEB128, and for the 0xBB typed values we use signed LEB128, but it isn't specified anywhere else. Maybe that should be clarified in the images and presentation.
@vshymanskyy
Copy link
Owner

That's correct. Will be documented soon

@vshymanskyy
Copy link
Owner

Related to #8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
planned question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JobLeonard @vshymanskyy