From 124d26b6987e85db664b8dca9d032ca5d04ee618 Mon Sep 17 00:00:00 2001 From: Wender Date: Thu, 10 Oct 2024 08:16:00 -0400 Subject: [PATCH] [FSEUS-521] Error changing Cost Center after placing order (#165) --- CHANGELOG.md | 4 ++ node/resolvers/Mutations/Users.ts | 75 ++++++++++++++++++++++++++----- vtex.session/configuration.json | 2 +- 3 files changed, 70 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4370d6b..cc26de4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] +### Fixed + +- Error changing Cost Center after placing order + ## [1.44.10] - 2024-10-07 ### Fixed diff --git a/node/resolvers/Mutations/Users.ts b/node/resolvers/Mutations/Users.ts index 9ff0366..f86694b 100644 --- a/node/resolvers/Mutations/Users.ts +++ b/node/resolvers/Mutations/Users.ts @@ -11,6 +11,48 @@ import { const config: any = currentSchema('b2b_users') +const MAX_RETRY = 5 +const RETRY_BACKOFF_FACTOR_MS = 100 +const MAX_BACKOFF_MS = 1000 + +const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)) +const setChangeSession = async ( + sessionParameters: any, + countRetry = 0 +): Promise => { + const { + context: { + clients: { session }, + vtex: { logger }, + }, + publicKey, + value, + sessionCookie, + } = sessionParameters + + try { + await session.updateSession(publicKey, value, [], sessionCookie) + } catch (error) { + logger.error({ + error, + message: 'setChangeSession.error', + attempt: countRetry, + }) + + if (countRetry < MAX_RETRY) { + countRetry++ + const backoff = Math.min( + 2 ** (countRetry - 1) * RETRY_BACKOFF_FACTOR_MS, + MAX_BACKOFF_MS + ) + + await delay(backoff) + + return setChangeSession(sessionParameters, countRetry) + } + } +} + const addUserToMasterdata = async ({ masterdata, params: { name, email }, @@ -333,14 +375,18 @@ export const deleteUser = async (_: any, params: any, ctx: Context) => { export const impersonateUser = async (_: any, params: any, ctx: Context) => { const { - clients: { session }, vtex: { logger, sessionToken }, } = ctx const { userId } = params try { - await session.updateSession('impersonate', userId, [], sessionToken) + await setChangeSession({ + context: ctx, + publicKey: 'impersonate', + value: userId, + sessionCookie: sessionToken, + }) return { status: 'success', message: '' } } catch (error) { @@ -564,12 +610,14 @@ export const setCurrentOrganization = async ( ctx: Context ) => { const { + vtex: { logger }, cookies, request, - vtex: { logger }, - clients: { session }, } = ctx + const sessionCookie = + cookies.get('vtex_session') ?? request.header?.sessiontoken + const { sessionData } = ctx.vtex as any const { orgId, costId } = params @@ -600,11 +648,7 @@ export const setCurrentOrganization = async ( return { status: 'error', message: error } } - const sessionCookie = - cookies.get('vtex_session') ?? request.header?.sessiontoken - try { - await session.updateSession('', null, [], sessionCookie) await setActiveUserByOrganization( _, { @@ -626,6 +670,13 @@ export const setCurrentOrganization = async ( sendChangeTeamMetric(metricParams) + await setChangeSession({ + context: ctx, + publicKey: 'b2bCurrentCostCenter', + value: costId, + sessionCookie, + }) + return { status: 'success', message: '' } } catch (error) { logger.error({ @@ -646,14 +697,18 @@ export const ignoreB2BSessionData = async ( cookies, request, vtex: { logger }, - clients: { session }, } = ctx const sessionCookie = cookies.get('vtex_session') ?? request.header?.sessiontoken try { - await session.updateSession('removeB2B', enabled, [], sessionCookie) + await setChangeSession({ + context: ctx, + publicKey: 'removeB2B', + value: enabled, + sessionCookie, + }) return { status: 'success', message: '' } } catch (error) { diff --git a/vtex.session/configuration.json b/vtex.session/configuration.json index 7913ee8..3865f4e 100644 --- a/vtex.session/configuration.json +++ b/vtex.session/configuration.json @@ -4,7 +4,7 @@ "authentication": ["storeUserEmail"], "checkout": ["orderFormId"], "impersonate": ["storeUserEmail", "storeUserId"], - "public": ["impersonate", "removeB2B"] + "public": ["impersonate", "removeB2B", "b2bCurrentCostCenter"] }, "output": { "public": ["facets", "sc", "regionId"],