From c5c66684c21956a50b1887642b821b1ddc889275 Mon Sep 17 00:00:00 2001 From: Mariana Caetano Pereira <67270558+Mariana-Caetano@users.noreply.github.com> Date: Wed, 27 Apr 2022 10:11:41 -0300 Subject: [PATCH] Doc: Update PR template checklist (#12) * Doc: Update PR template checklist * Update CHANGELOG.md * Update pull_request_template.md * Update pull_request_template.md Co-authored-by: Filipe W. Lima * Update pull_request_template.md * Update CHANGELOG.md * Update pull_request_template.md * Update pull_request_template.md Co-authored-by: Filipe W. Lima --- CHANGELOG.md | 1 + pull_request_template.md | 12 +++++++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 550d8aee..ce6a1da8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ### Added +- New items in the `pull_request_template.md` ([#12](https://github.com/vtex-sites/gatsby.store/pull/12)) - Integrates with search.query event api (#2) - Applies new local tokens to `Badge` (#462) - Applies new local tokens to `Hero` (#435) diff --git a/pull_request_template.md b/pull_request_template.md index fcec8010..e165db90 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -20,4 +20,14 @@ You may erase this after checking them all ;) -- [] CHANGELOG entry added +- [ ] Added an entry in the `CHANGELOG.md` at the beginning of its due section. [The latest version should comes first](https://keepachangelog.com/en/1.0.0/#:~:text=The%20latest%20version%20comes%20first.). +- [ ] Added the PR number with the PR link at the entry in the `CHANGELOG.md`. E.g., *New items in the `pull_request_template.md` ([#12](https://github.com/vtex-sites/gatsby.store/pull/12))* + + +- PR description +- [ ] Updated the Storybook - *if applicable*. +- [ ] Added a label according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. +- [ ] Added the component, hook, or pathname in-between backticks (``) *- If applicable*. E.g., *`ComponentName` component*. +- [ ] Identified the function or parameter in the PR *- If applicable*. E.g., *`useWindowDimensions` hook*. +- [ ] For documentation changes, ping @carolinamenezes or @Mariana-Caetano to review and update the changes. +