Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prop for page header background color #2036

Open
matheusps opened this issue Oct 29, 2024 · 5 comments
Open

Prop for page header background color #2036

matheusps opened this issue Oct 29, 2024 · 5 comments
Assignees
Labels
proposal Proposals for enhancements to the software

Comments

@matheusps
Copy link
Contributor

Problem

There are designs where the background is soft instead of base. This is not supported by the Page component by default.

Solution

Accept a variant on the page

<Page variant="soft | base">

Usage examples

No response

Dependencies

No response

References

Figma Page: https://www.figma.com/design/xmWRVrjShWlZwchJg0huzZ/Product-%E2%80%93-FastStore-WebOps-v2?node-id=929-75490&node-type=frame&m=dev.

@matheusps matheusps added the proposal Proposals for enhancements to the software label Oct 29, 2024
@matheusps matheusps self-assigned this Oct 29, 2024
@beatrizmilhomem
Copy link
Contributor

Agreed!

Related issue to define the pattern #1788

@beatrizmilhomem beatrizmilhomem moved this to Active in Shoreline Oct 29, 2024
@renatamottam
Copy link

Nice! This background is being used on dashboards proposals. It'll definitely help :)

@davicostalf davicostalf changed the title Page Prop for page header background color Oct 30, 2024
@davicostalf
Copy link
Contributor

davicostalf commented Oct 30, 2024

  • Have we decided on changing the page header background color based on the page background. I'm all for it, but I remember there were hold outs.

  • I'm worried about calling this prop variant. We may have different types of page headers in the future, with differences other than just the background color.

  • One token is called bg-base and the other is bg-base-soft. Won't it be confusing for the prop values to be named soft and base?

@lucasaarcoverde
Copy link
Contributor

One token is called bg-base and the other is bg-base-soft. Won't it be confusing for the prop values to be named soft and base?

I agree with that! Maybe we should take the primary and secondary approaches, which would open space for other variants

@felipepowlist
Copy link

Isn't it a matter of the header having a background color vs being transparent? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal Proposals for enhancements to the software
Projects
Status: Active
Development

No branches or pull requests

6 participants