Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pyre to read configuration from pyproject.toml #1

Closed
xshapira opened this issue Jun 1, 2024 · 3 comments
Closed

Allow pyre to read configuration from pyproject.toml #1

xshapira opened this issue Jun 1, 2024 · 3 comments

Comments

@xshapira
Copy link

xshapira commented Jun 1, 2024

Thanks for the effort to make this extension happen!

If pyre can use the pyproject.toml file for its settings like most tools do, that would be awesome.

This might help:
facebook/pyre-check#799

@vthemelis
Copy link
Owner

vthemelis commented Jun 1, 2024

Hello! I think that this is one for the core pyre library (as this is what is reading all the config). Should I delegate this to facebook/pyre-check#695 ?

@xshapira
Copy link
Author

xshapira commented Jun 2, 2024

@vthemelis Yes, you should. That request was created two years ago.

The Pyre team has gone radio silent on us.

@vthemelis
Copy link
Owner

vthemelis commented Jun 2, 2024

Thanks! Will close this in favour of the original pyre-check issue. I can see how this sort of thing may not be at the top of their priorities.

FWIW I find that using pyproject.toml for everything can get a bit unergonomoc so I opt in for separate config files when I can. :)

@vthemelis vthemelis closed this as not planned Won't fix, can't repro, duplicate, stale Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants