Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postcss-import & postcss-url missing #143

Closed
rathesDot opened this issue Dec 30, 2017 · 5 comments
Closed

postcss-import & postcss-url missing #143

rathesDot opened this issue Dec 30, 2017 · 5 comments

Comments

@rathesDot
Copy link

Both postcss plugins used in webpack template are missing here. Are they left out intentionally or can I just send a PR to add them?
@jeffposnick
Copy link
Collaborator

A PR would definitely be welcome. See https://github.com/vuejs-templates/pwa#contributing

@rathesDot
Copy link
Author

Just for my better understanding, as I'm new to contributing: The upstream already uses this packages, so I can simply send the PR to this template, can I?

@jeffposnick
Copy link
Collaborator

Yup, if you can locate the PR that added it to the webpack template, creating a PR with the same contents against this repo would be the best path forward.

@rathesDot
Copy link
Author

Just a last question: It is currently not possible to test my current implementation, when it is in a feature-branch, is it? So I would have to work in development of my fork and then send a PR, is that right?

@anubhav7495
Copy link
Collaborator

Closing issue since relevant PR has been made #149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jeffposnick @rathesDot @anubhav7495