From 1b7145b917d5422fe638d305147c90c356ec915c Mon Sep 17 00:00:00 2001
From: waynzh <zhanghaowei19W@gmail.com>
Date: Sat, 2 Dec 2023 20:56:50 +0800
Subject: [PATCH 1/3] fix(no-unused-emit-declarations): detect emits in
 templates

---
 lib/rules/no-unused-emit-declarations.js      | 20 ++++++++++++
 .../lib/rules/no-unused-emit-declarations.js  | 32 +++++++++++++++++--
 2 files changed, 50 insertions(+), 2 deletions(-)

diff --git a/lib/rules/no-unused-emit-declarations.js b/lib/rules/no-unused-emit-declarations.js
index f96004a36..37b7e6fc0 100644
--- a/lib/rules/no-unused-emit-declarations.js
+++ b/lib/rules/no-unused-emit-declarations.js
@@ -56,6 +56,17 @@ function hasReferenceId(value, setupContext) {
   )
 }
 
+/**
+ * Check if the given name matches emitReferenceIds variable name
+ * @param {string} name
+ * @param {Set<Identifier>} emitReferenceIds
+ * @returns {boolean}
+ */
+function verifyEmitVariableName(name, emitReferenceIds) {
+  const emitVariable = emitReferenceIds.values().next().value.name
+  return emitVariable === name
+}
+
 module.exports = {
   meta: {
     type: 'suggestion',
@@ -191,6 +202,15 @@ module.exports = {
           }
 
           const { contextReferenceIds, emitReferenceIds } = setupContext
+
+          // verify defineEmits variable in template
+          if (
+            callee.type === 'Identifier' &&
+            verifyEmitVariableName(callee.name, emitReferenceIds)
+          ) {
+            addEmitCall(node)
+          }
+
           // verify setup(props,{emit}) {emit()}
           addEmitCallByReference(callee, emitReferenceIds, node)
           if (emit && emit.name === 'emit') {
diff --git a/tests/lib/rules/no-unused-emit-declarations.js b/tests/lib/rules/no-unused-emit-declarations.js
index 0667ad464..de38d1aac 100644
--- a/tests/lib/rules/no-unused-emit-declarations.js
+++ b/tests/lib/rules/no-unused-emit-declarations.js
@@ -98,6 +98,16 @@ tester.run('no-unused-emit-declarations', rule, {
         }
       `
     },
+    {
+      filename: 'test.vue',
+      code: `
+      <template>
+        <button @click="emits('bar')">Bar</button>
+      </template>
+      <script setup>
+        const emits = defineEmits(['bar'])
+      `
+    },
     {
       filename: 'test.vue',
       code: `
@@ -237,7 +247,7 @@ tester.run('no-unused-emit-declarations', rule, {
         export default {
           emits: ['foo'],
           setup(_, context) {
-            useCustomComposable({ emit: context.emit }) 
+            useCustomComposable({ emit: context.emit })
           }
         }
       </script>
@@ -282,7 +292,7 @@ tester.run('no-unused-emit-declarations', rule, {
         export default {
           emits: ['foo'],
           setup(_, { emit }) {
-            useCustomComposable({ emit: emit }) 
+            useCustomComposable({ emit: emit })
           }
         }
       </script>
@@ -453,6 +463,24 @@ tester.run('no-unused-emit-declarations', rule, {
         }
       ]
     },
+    {
+      filename: 'test.vue',
+      code: `
+      <template>
+        <button @click="emit('bar')">Bar</button>
+      </template>
+      <script setup>
+        const emit = defineEmits(['foo', 'bar'])
+      `,
+      errors: [
+        {
+          messageId: 'unused',
+          line: 6,
+          column: 35,
+          endColumn: 40
+        }
+      ]
+    },
     {
       filename: 'test.vue',
       code: `

From cd15f7dd58bdbb57edfc828463ae7f4176f712d7 Mon Sep 17 00:00:00 2001
From: Flo Edelmann <git@flo-edelmann.de>
Date: Mon, 4 Dec 2023 15:45:24 +0100
Subject: [PATCH 2/3] Add missing end tags in test cases

---
 tests/lib/rules/no-unused-emit-declarations.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tests/lib/rules/no-unused-emit-declarations.js b/tests/lib/rules/no-unused-emit-declarations.js
index de38d1aac..10bf3b33a 100644
--- a/tests/lib/rules/no-unused-emit-declarations.js
+++ b/tests/lib/rules/no-unused-emit-declarations.js
@@ -106,6 +106,7 @@ tester.run('no-unused-emit-declarations', rule, {
       </template>
       <script setup>
         const emits = defineEmits(['bar'])
+      </script>
       `
     },
     {
@@ -471,6 +472,7 @@ tester.run('no-unused-emit-declarations', rule, {
       </template>
       <script setup>
         const emit = defineEmits(['foo', 'bar'])
+      </script>
       `,
       errors: [
         {

From 00b7bc4145d40119d3e7a733e6f8c5f57e7cdd3a Mon Sep 17 00:00:00 2001
From: Flo Edelmann <git@flo-edelmann.de>
Date: Wed, 13 Dec 2023 18:02:29 +0100
Subject: [PATCH 3/3] Rename function

---
 lib/rules/no-unused-emit-declarations.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/rules/no-unused-emit-declarations.js b/lib/rules/no-unused-emit-declarations.js
index 37b7e6fc0..ee43248cb 100644
--- a/lib/rules/no-unused-emit-declarations.js
+++ b/lib/rules/no-unused-emit-declarations.js
@@ -62,7 +62,7 @@ function hasReferenceId(value, setupContext) {
  * @param {Set<Identifier>} emitReferenceIds
  * @returns {boolean}
  */
-function verifyEmitVariableName(name, emitReferenceIds) {
+function isEmitVariableName(name, emitReferenceIds) {
   const emitVariable = emitReferenceIds.values().next().value.name
   return emitVariable === name
 }
@@ -206,7 +206,7 @@ module.exports = {
           // verify defineEmits variable in template
           if (
             callee.type === 'Identifier' &&
-            verifyEmitVariableName(callee.name, emitReferenceIds)
+            isEmitVariableName(callee.name, emitReferenceIds)
           ) {
             addEmitCall(node)
           }