Using URLSearchParams for query

[niksy]

Is there a reason why query doesn’t support passing URLSearchParams instance directly? We can transform it to plain object with Object.fromEntries, but it would be really nice if it can accept search params instance to align with the web platform.

[posva]

Historically, it wasn't supported for compatibility reasons but nowadays, the main issue with URLSearchParams is its poor performance.

[niksy]

What do you mean by poor performance? Are there any recent benchmarks on this?

Internally, router could use existing approach (and should if performance is an issue) but allowing URLSearchParams as input and handling it with new codepath which results in same output (so the possible performance issue is on implementor side) can be good compromise for achieveing alignment with the platform; e.g. fetch accepts it, and we can see other projects also promote it as default way of passing query parameters for requests.

[posva]

Since it’s a one line in userland, it’s fine like this. I wouldn’t recommend using it in every scenario, in most cases, it’s dx is also worse (eg no spread merge)

I don’t have the links right now, but you can benchmark it easily on parsing and serialization and compare it with Vue router implementation, the difference is huge 🙃