Skip to content

Commit e1f1430

Browse files
committed
fix test issues for babel 6
1 parent 063593b commit e1f1430

File tree

5 files changed

+17
-9
lines changed

5 files changed

+17
-9
lines changed

lib/loader.js

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ module.exports = function (content) {
2929
var options = this.options.vue || {}
3030
var vueUrl = loaderUtils.getRemainingRequest(this)
3131

32+
// respect user babel options
33+
if (this.options.babel) {
34+
defaultLoaders.js = 'babel'
35+
}
36+
3237
// check if there are custom loaders specified with
3338
// vueLoader.withLoaders(), otherwise use defaults
3439
var loaders = assign({}, defaultLoaders, options.loaders)
@@ -139,8 +144,9 @@ module.exports = function (content) {
139144

140145
// add require for script
141146
if (parts.script.length) {
142-
output += 'module.exports = ' +
143-
getRequire('script', parts.script[0], 0)
147+
output +=
148+
'module.exports = ' + getRequire('script', parts.script[0], 0) + '\n' +
149+
'if (module.exports.__esModule) module.exports = module.exports.default\n'
144150
}
145151

146152
// add require for template
@@ -178,6 +184,7 @@ module.exports = function (content) {
178184
'hotAPI.createRecord(id, module.exports)\n' +
179185
'module.hot.accept(' + JSON.stringify(accepted) + ', function () {\n' +
180186
'var newOptions = ' + (scriptString ? 'require(' + scriptString + ')\n' : 'null\n') +
187+
'if (newOptions.__esModule) newOptions = newOptions.default\n' +
181188
'var newTemplate = ' + (templateString ? 'require(' + templateString + ')\n' : 'null\n') +
182189
'hotAPI.update(id, newOptions, newTemplate)\n' +
183190
'})\n' +

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"homepage": "https://github.com/vuejs/vue-loader",
2121
"scripts": {
2222
"lint": "eslint lib",
23-
"test": "eslint lib && mocha test/test.js --slow 5000"
23+
"test": "eslint lib && mocha test/test.js --slow 5000 --timeout 10000"
2424
},
2525
"dependencies": {
2626
"autoprefixer": "^6.0.3",
@@ -35,17 +35,18 @@
3535
"vue-html-loader": "^1.0.0",
3636
"css-loader": "^0.21.0",
3737
"style-loader": "^0.13.0",
38-
"babel-loader": "^6.0.1",
38+
"babel-loader": "^6.1.0",
3939
"babel-plugin-transform-runtime": "^6.1.2",
4040
"babel-preset-es2015": "^6.1.2",
4141
"babel-runtime": "^6.0.14",
4242
"vue-hot-reload-api": "^1.2.0"
4343
},
4444
"devDependencies": {
4545
"babel-core": "^6.1.2",
46-
"babel-loader": "^6.0.1",
46+
"babel-loader": "^6.1.0",
4747
"babel-plugin-transform-runtime": "^6.1.2",
4848
"babel-preset-es2015": "^6.1.2",
49+
"babel-runtime": "^6.0.14",
4950
"chai": "^3.0.0",
5051
"css-loader": "^0.21.0",
5152
"eslint": "^1.6.0",

test/fixtures/basic.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ comp-a h2 {
99
</template>
1010

1111
<script>
12-
module.exports = {
13-
data: function () {
12+
export default {
13+
data () {
1414
return {
1515
msg: 'Hello from Component A!'
1616
}

test/fixtures/pre.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ comp-a
1212
comp-b
1313
</template>
1414

15-
<script lang="babel">
15+
<script>
1616
export default {
1717
data () {
1818
return {

test/test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ describe('vue-loader', function () {
4343
function test (options, assert) {
4444
var config = assign({}, globalConfig, options)
4545
webpack(config, function (err) {
46-
expect(err).to.be.null
46+
if (err) throw err
4747
getFile('test.build.js', function (data) {
4848
jsdom.env({
4949
html: testHTML,

0 commit comments

Comments
 (0)