Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add plugin-markdown-chart #249

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: add plugin-markdown-chart #249

wants to merge 1 commit into from
+6,845 −109

Conversation

Mister-Hope
Copy link
Member

No description provided.

@Mister-Hope Mister-Hope linked an issue Sep 20, 2024 that may be closed by this pull request
[Feature request] add @vuepress/plugin-markdown-chart #146
Open
@Mister-Hope Mister-Hope force-pushed the plugin-markdown-chart branch from 89fa630 to b09f322 Compare October 1, 2024 04:13
@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12048684625

Details

  • 104 of 105 (99.05%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.8%) to 61.794%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-markdown-chart/src/node/markdown-it-plugins/mermaid.ts 20 21 95.24%
Totals Coverage Status
Change from base Build 12048410848: 1.8%
Covered Lines: 1411
Relevant Lines: 2075
💛 - Coveralls

@Mister-Hope
Copy link
Member Author

@pengzhanbo I have some issues with katex in markmap, helps would be appreciated.

@pengzhanbo
Copy link
Member

pengzhanbo commented Oct 13, 2024 •
edited
Loading

I have some issues with katex in markmap, helps would be appreciated.

I haven't used markmap before. I read its documentation and the code of the Markmap component in the plugin, and I did not find any obvious issues. However, I noticed that markmap-view depends on d3, and I'm not sure if that has any impact. Perhaps we can refer to markmap-autoloader to adjust the loading logic of the markmap component.

@Mister-Hope Mister-Hope force-pushed the plugin-markdown-chart branch from 203dcb9 to d4bad4a Compare October 22, 2024 11:05
@netlify Netlify
Copy link

netlify bot commented Nov 27, 2024 •
edited
Loading

✅ Deploy Preview for vuepress-ecosystem ready!

Name Link
🔨 Latest commit 01b02ba
🔍 Latest deploy log https://app.netlify.com/sites/vuepress-ecosystem/deploys/6746f8698f03e3000740bd4c
😎 Deploy Preview https://deploy-preview-249--vuepress-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Mister-Hope Mister-Hope force-pushed the plugin-markdown-chart branch from 62f68aa to 01b02ba Compare November 27, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature request] add @vuepress/plugin-markdown-chart
3 participants
@Mister-Hope @coveralls @pengzhanbo