pref(createEventHook): optimize EventHookTrigger to support multiple parameters (#4111)

Author: zyyv

packages/shared/createEventHook/index.test.ts

@@ -134,4 +134,20 @@ describe('createEventHook', () => {
     off(listener)
     expect(listener).toBeCalledTimes(1)
   })
+
+  it('multiple parameters on trigger with types', () => {
+    let id = ''
+    const list: unknown[] = []
+    const { on: onResult, trigger } = createEventHook<string>()
+
+    onResult(_id => id = _id)
+    onResult((str, ...rest) => {
+      list.push(str, ...rest)
+    })
+
+    trigger('foo', 1, true, 'bar')
+
+    expect(id).toEqual('foo')
+    expect(list).toEqual(['foo', 1, true, 'bar'])
+  })
 })

packages/shared/createEventHook/index.ts

@@ -8,16 +8,16 @@ import { tryOnScopeDispose } from '../tryOnScopeDispose'
 // any extends void = true
 // so we need to check if T is any first
 type Callback<T> = IsAny<T> extends true
-  ? (param: any) => void
+  ? (...param: any) => void
   : (
       [T] extends [void]
-        ? () => void
-        : (param: T) => void
+        ? (...param: unknown[]) => void
+        : (...param: [T, ...unknown[]]) => void
     )
 
 export type EventHookOn<T = any> = (fn: Callback<T>) => { off: () => void }
 export type EventHookOff<T = any> = (fn: Callback<T>) => void
-export type EventHookTrigger<T = any> = (param?: T) => Promise<unknown[]>
+export type EventHookTrigger<T = any> = (...param: IsAny<T> extends true ? unknown[] : [T, ...unknown[]]) => Promise<unknown[]>
 
 export interface EventHook<T = any> {
   on: EventHookOn<T>
@@ -49,7 +49,7 @@ export function createEventHook<T = any>(): EventHook<T> {
   }
 
   const trigger: EventHookTrigger<T> = (...args) => {
-    return Promise.all(Array.from(fns).map(fn => fn(...(args as [T]))))
+    return Promise.all(Array.from(fns).map(fn => fn(...(args as [T, ...unknown[]]))))
   }
 
   return {