Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Docker Swarm #225

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for Docker Swarm #225

wants to merge 2 commits into from

Conversation

beornf
Copy link
Contributor

@beornf beornf commented Jun 27, 2024

Description

This PR adds support for Docker Swarm. The CSI plugin could also be pushed in a Github workflow to the tag vultr/vultr-csi.

Related Issues

Fixes #179.

@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
?   	github.com/vultr/vultr-csi/cmd/csi-vultr-driver	[no test files]%0A=== RUN   TestCreateVolume%0Atime="2024-06-27T07:31:40Z" level=info msg="Create Volume: called" capabilities="[mount:<> access_mode:<mode:SINGLE_NODE_WRITER > ]" test="create volume" volume-name=volume-test-name%0Atime="2024-06-27T07:31:41Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-06-27T07:31:41Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-06-27T07:31:41Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-06-27T07:31:41Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-06-27T07:31:41Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-06-27T07:31:41Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-06-27T07:31:41Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0A	github.com/vultr/vultr-csi/driver	coverage: 26.8%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	1.008s	coverage: 26.8%25 of statements

Pusher: @beornf, Action: pull_request_target

@happytreees happytreees added the enhancement New feature or request label Sep 21, 2024
@github-actions GitHub Actions
Copy link

Unit Tests and Coverage

Show Output 
	github.com/vultr/vultr-csi/cmd/csi-vultr-driver		coverage: 0.0%25 of statements%0A=== RUN   TestCreateVolume%0Atime="2024-10-30T18:23:04Z" level=info msg="Create Volume: called" capabilities="[mount:{}  access_mode:{mode:SINGLE_NODE_WRITER}]" test="create volume" volume-name=volume-test-name%0Atime="2024-10-30T18:23:05Z" level=info msg="Create Volume: created volume" size=10737418240 test="create volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec volume-name=test-bs volume-size=10%0A--- PASS: TestCreateVolume (1.00s)%0A=== RUN   TestDeleteVolume%0Atime="2024-10-30T18:23:05Z" level=info msg="Delete volume: called" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0Atime="2024-10-30T18:23:05Z" level=info msg="Delete Volume: deleted" test="delete volume" volume-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec%0A--- PASS: TestDeleteVolume (0.00s)%0A=== RUN   TestPublishVolume%0A--- PASS: TestPublishVolume (0.00s)%0A=== RUN   TestUnPublishVolume%0Atime="2024-10-30T18:23:05Z" level=info msg="Controller Publish Unpublish: called" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0Atime="2024-10-30T18:23:05Z" level=info msg="Controller Unublish Volume: unpublished" node-id=c56c7b6e-15c2-445e-9a5d-1063ab5828ec test="delete volume" volume-id=245bb2fe-b55c-44a0-9a1e-ab80e4b5f088%0A--- PASS: TestUnPublishVolume (0.00s)%0A=== RUN   TestDriverSuite%0A--- PASS: TestDriverSuite (0.00s)%0APASS%0Atime="2024-10-30T18:23:05Z" level=info msg="Start listening with scheme unix, addr /tmp/csi.sock"%0Atime="2024-10-30T18:23:05Z" level=info msg="Listening for connections on address: &net.UnixAddr{Name:"/tmp/csi.sock", Net:"unix"}" address=/tmp/csi.sock proto=unix%0Acoverage: 29.2%25 of statements%0Aok  	github.com/vultr/vultr-csi/driver	1.006s	coverage: 29.2%25 of statements

Pusher: @optik-aper, Action: pull_request_target

@optik-aper
Copy link
Member

@beornf Thanks for taking the time to get this set up. Do you have a procedure for testing a CSI in Moby/Docker swarm? Or a link to some? I've started reviewing other CSIs but immediately noticed that there are discrepancies between those and ours. I just want to know how this is to be used in order to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@optik-aper optik-aper Awaiting requested review from optik-aper

@happytreees happytreees Awaiting requested review from happytreees happytreees is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@beornf beornf

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] - Support for Docker Swarm
3 participants
@beornf @optik-aper @happytreees