Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS doesn't use variables in most places #12

Open
antgel opened this issue Dec 20, 2020 · 1 comment
Open

CSS doesn't use variables in most places #12

antgel opened this issue Dec 20, 2020 · 1 comment

Comments

@antgel
Copy link

antgel commented Dec 20, 2020

At the very start of creative.scss, we have a list of variables, but in most places from then on, the CSS hash colour codes are used. This makes it less readable and bug-prone. For example:

23:44 $ git grep 17a2b8
assets/css/creative.scss:  --cyan: #17a2b8;
assets/css/creative.scss:  --info: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  border-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8;
assets/css/creative.scss:  background-color: #17a2b8 !important;
assets/css/creative.scss:  border-color: #17a2b8 !important;
assets/css/creative.scss:  color: #17a2b8 !important;

Surely those later entries should use var(--cyan) or var(--info)?

Also, secondary isn't used anywhere. The members and timeline sections have prominent background colours, but neither is secondary.

Edit: Also, lots of the variables are unused. Although I see this file is from upstream, so I guess we won't fix it here, feel free to close if so.

@vvalchev
Copy link
Owner

The design comes from https://github.com/startbootstrap/startbootstrap-creative. I've just made it Jekyll-friendly.
To make it easier I try to keep the code here up-to-date with the latest startbootstrap-creative theme releases.

Maybe you can create issue in the original source. Or even better - submit them a patch. When they make a new official release I'm going to update the sources here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants