-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increasing the width shows a scroll bar #5
Comments
hi Nasser, glad you find the plugin useful! part 1:
part 2:
|
For part 2:
2022-05-21.11-51-38.mp4 |
that's odd - could you uninstall the plugin, download the release from github, and load it manually? also, i don't think the issue has to do w/ the video itself, but could you send me the video link so that i can test it on my end? |
I tried another video and I get the same result. |
I tried to load it manually from github, and I get the same behaviour. |
can you follow the video attached to use dev tools to inspect the +/- buttons for the height? at the end of the video, i showed that i can't reproduce the error you're facing logseq_helium_issue5_demo.mp4 |
Thanks for that, I see that you are using a mac and I'm using linux, it could be an issue with my distro, I'm using logseq on NixOS and it might be an issue with my setup, I'll try to test it with another machine and get back to you. |
- feat: add keyboard shortcuts to 1) play/pause and 2) skip forward/backward timestamp for youtube and local videos - feat: increasing the width of videos no longer shows the overflow scroll bar (addresses #5) - feat: local videos can be resized (addresses #8) - refactor: update `startFloat(e)` to support the new `{{video URL}}` macro in Logseq version 0.7.0+ (addresses #7)
- feat: add keyboard shortcuts to 1) play/pause and 2) skip forward/backward timestamp for youtube and local videos - feat: increasing the width of videos no longer shows the overflow scroll bar (addresses #5) - feat: local videos can be resized (addresses #7) - refactor: update `startFloat(e)` to support the new `{{video URL}}` macro in Logseq version 0.7.0+ (addresses #8)
figured out a solution to part 1! check out v.2.0.0 🙂 |
Hello @vyleung good job 👍 , yes I confirm that par1 issue is resolved with |
First of all, thank you @vyleung for this plugin, it's really useful!
I noticed a little issue today as shown in the following video:
2022-05-20.21-56-14.mp4
As you can see, whenever I try to increase the width, the video div seems to have a css property of
overflow: scroll;
or something like that. And theH
button doesn't work and doesnt affect the height of the video.I'm using logseq version 0.6.8 on my linux machine.
The text was updated successfully, but these errors were encountered: