Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing the width shows a scroll bar #5

Open
nashamri opened this issue May 20, 2022 · 9 comments
Open

Increasing the width shows a scroll bar #5

nashamri opened this issue May 20, 2022 · 9 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@nashamri
Copy link

First of all, thank you @vyleung for this plugin, it's really useful!

I noticed a little issue today as shown in the following video:

2022-05-20.21-56-14.mp4

As you can see, whenever I try to increase the width, the video div seems to have a css property of overflow: scroll; or something like that. And the H button doesn't work and doesnt affect the height of the video.

I'm using logseq version 0.6.8 on my linux machine.

@vyleung vyleung self-assigned this May 20, 2022
@vyleung vyleung added bug Something isn't working enhancement New feature or request labels May 20, 2022
@vyleung
Copy link
Owner

vyleung commented May 20, 2022

hi Nasser, glad you find the plugin useful!

part 1:

whenever I try to increase the width, the video div seems to have a css property of overflow: scroll; or something like that.

  • this is currently a limitation since i use position: sticky to get the block to stick to the top of the page and can't use position: absolute to show the overflow - i'll try my best to find a solution to this, but no promises

part 2:

And the H button doesn't work and doesnt affect the height of the video.

  • i'm not able to reproduce this error - some troubleshooting questions:
  1. are you on the latest version of the plugin (v.1.1.4)?
  2. can you try disabling/re-enabling the plugin and refresh Logseq?
  3. are there any errors in dev tools (you can open it using ctrl+shift+i)?

@nashamri
Copy link
Author

For part 2:

  1. Yes I'm using v.1.1.4
  2. Tried that and restarted Logseq and the issue still there.
  3. From what I see, I don't think there are any errors that show up in the console. I've make a little video demoing that:
2022-05-21.11-51-38.mp4

@vyleung
Copy link
Owner

vyleung commented May 21, 2022

that's odd - could you uninstall the plugin, download the release from github, and load it manually?

also, i don't think the issue has to do w/ the video itself, but could you send me the video link so that i can test it on my end?

@nashamri
Copy link
Author

I tried another video and I get the same result.
Here's the link to the video anyways:
https://www.youtube.com/watch?v=OyfBQmvr2Hc

@nashamri
Copy link
Author

I tried to load it manually from github, and I get the same behaviour.

@vyleung
Copy link
Owner

vyleung commented May 21, 2022

can you follow the video attached to use dev tools to inspect the +/- buttons for the height? at the end of the video, i showed that i can't reproduce the error you're facing

logseq_helium_issue5_demo.mp4

@nashamri
Copy link
Author

Thanks for that, I see that you are using a mac and I'm using linux, it could be an issue with my distro, I'm using logseq on NixOS and it might be an issue with my setup, I'll try to test it with another machine and get back to you.

vyleung added a commit that referenced this issue Jun 3, 2022
- feat: add keyboard shortcuts to 1) play/pause and 2) skip forward/backward timestamp for youtube and local videos
- feat: increasing the width of videos no longer shows the overflow scroll bar (addresses #5)
- feat: local videos can be resized (addresses #8)
- refactor: update `startFloat(e)` to support the new `{{video URL}}` macro in Logseq version 0.7.0+ (addresses #7)
vyleung added a commit that referenced this issue Jun 3, 2022
- feat: add keyboard shortcuts to 1) play/pause and 2) skip forward/backward timestamp for youtube and local videos
- feat: increasing the width of videos no longer shows the overflow scroll bar (addresses #5)
- feat: local videos can be resized (addresses #7)
- refactor: update `startFloat(e)` to support the new `{{video URL}}` macro in Logseq version 0.7.0+ (addresses #8)
@vyleung
Copy link
Owner

vyleung commented Jun 3, 2022

figured out a solution to part 1! check out v.2.0.0 🙂

@nashamri
Copy link
Author

nashamri commented Jun 3, 2022

Hello @vyleung good job 👍 , yes I confirm that par1 issue is resolved with v2.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants