Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model must be upgraded #26

Open
Cafeepy opened this issue Sep 30, 2020 · 2 comments
Open

Model must be upgraded #26

Cafeepy opened this issue Sep 30, 2020 · 2 comments

Comments

@Cafeepy
Copy link

Cafeepy commented Sep 30, 2020

The sklearn model used in this package was made for sklearn version 0.20.2. The latest stable version of sklearn is 0.23.2, and it is not compatible with the model from 0.20.2. When trying to run this package on sklearn 0.23 or greater, you'll encounter an unavoidable unpickling error of sorts. Yes, it is possible to install an earlier version of sklearn but versions before version 0.22 are not compatible with Python 3.8. As others have noted, there is also a significant performance decrease when using sklearn 0.22.2 and several warnings warn about lack of backwards compatibility at runtime.

If this library is to be maintained, all I ask is that the model be upgraded/retrained to be compatible with sklearn 0.23.2 and Python 3.8, or at least the code/data used to train the original model be provided to allow others to retrain the model themselves. Going forward into Python 3.9 and greater, this library will unfortunately fall into deprecation unless this happens.

I really admire this library, honestly all it needs now is a bit of polishing. Thanks for your time!

@AlexYurkin
Copy link

I found an article the author wrote. It contains information about datasets he uses.
https://towardsdatascience.com/building-a-better-profanity-detection-library-with-scikit-learn-3638b2f2c4c2

@yaskh
Copy link

yaskh commented Dec 28, 2020

@Cafeepy this article contains the script using which the model was trained.
Found this link the pypi of profanity-check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants