Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Python >=3.7 and Scikit-Learn>=1.2 #44

Open
EthanJamesLew opened this issue May 4, 2023 · 5 comments
Open

Support for Python >=3.7 and Scikit-Learn>=1.2 #44

EthanJamesLew opened this issue May 4, 2023 · 5 comments

Comments

@EthanJamesLew
Copy link

EthanJamesLew commented May 4, 2023

While profanity-check has proven to be a useful model, there seems to be difficulties getting it to work with Python versions above 3.7.0. This issue could be addressed by switching to new joblib files or exploring alternative serialized forms that are more future-proof and backwards compatible. I am willing to help with a fix, but I acknowledge that upgrading models in scikit can be tricky.

Also, is this repository currently maintained?

@BradKML
Copy link

BradKML commented May 15, 2023

Very likely there is only active forks since updates stopped 2020.

@nsde
Copy link

nsde commented Aug 30, 2023

Any updates on this? Anyone willing to fork

@EthanJamesLew
Copy link
Author

@nsde I have not forked this as my use case for it didn't work out. It should be pretty straightforward to load up the model in the old python and serialize it out in a way that can be loaded in a more recent model version.

@suvanbalu
Copy link

suvanbalu commented Sep 21, 2023

image While checking the documentation of sklearn, one of the errors I got was that they depreciated joblib, instead, we can try installing joblib directly from pip.

Can someone see to this issue.

@dimitrismistriotis
Copy link
Contributor

I have seen it in other issues, we (me + friend) have forked it here following Scikit Learn's releases: https://github.com/dimitrismistriotis/alt-profanity-check

This will cover the Python version issue as well.

Apologies to the original author as I am creating Merge Requests on that repo and reach this one as it is the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants