Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates v3-unstable context to follow best practices #70

Merged
merged 1 commit into from
Nov 12, 2020
Merged

feat: updates v3-unstable context to follow best practices #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
237 changes: 236 additions & 1 deletion contexts/security-v3-unstable.jsonld
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
{
"@version": 1.1
},
"https://w3id.org/security/v2",
{
"id": "@id",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also have "@protected": true at the top level of this context.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed as well now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of @protected ended up breaking many different tests in the BBS suite. I haven't been able to dig in and figure out what is the cause of this yet. The error I'm getting is that I'm redefining protected terms though.

Copy link
Collaborator

@OR13 OR13 Nov 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest opening an issue, and working to address it with better tests separately... the context you are editing is already marked as unstable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdenhartog -- it sounds like adding @protected may have successfully surfaced errors that weren't getting detected previously in the BBS suite. The cause of those errors should be determined, we shouldn't turn off protection just to avoid them.

"type": "@type",
"JsonWebKey2020": {
"@id": "https://w3id.org/security#JsonWebKey2020"
},
Expand Down Expand Up @@ -167,7 +168,241 @@
"@type": "@id"
}
}
},

"EcdsaKoblitzSignature2016": "https://w3id.org/security#EcdsaKoblitzSignature2016",
"Ed25519Signature2018": {
"@id": "https://w3id.org/security#Ed25519Signature2018",
"@context": {
"@version": 1.1,
"@protected": true,

"id": "@id",
"type": "@type",

"sec": "https://w3id.org/security#",
"xsd": "http://www.w3.org/2001/XMLSchema#",

"challenge": "sec:challenge",
"created": {"@id": "http://purl.org/dc/terms/created", "@type": "xsd:dateTime"},
"domain": "sec:domain",
"expires": {"@id": "sec:expiration", "@type": "xsd:dateTime"},
"jws": "sec:jws",
"nonce": "sec:nonce",
"proofPurpose": {
"@id": "sec:proofPurpose",
"@type": "@vocab",
"@context": {
"@version": 1.1,
"@protected": true,

"id": "@id",
"type": "@type",

"sec": "https://w3id.org/security#",

"assertionMethod": {"@id": "sec:assertionMethod", "@type": "@id", "@container": "@set"},
"authentication": {"@id": "sec:authenticationMethod", "@type": "@id", "@container": "@set"}
}
},
"proofValue": "sec:proofValue",
"verificationMethod": {"@id": "sec:verificationMethod", "@type": "@id"}
}
},
"EncryptedMessage": "https://w3id.org/security#EncryptedMessage",
"GraphSignature2012": "https://w3id.org/security#GraphSignature2012",
"LinkedDataSignature2015": "https://w3id.org/security#LinkedDataSignature2015",
"LinkedDataSignature2016": "https://w3id.org/security#LinkedDataSignature2016",
"CryptographicKey": "https://w3id.org/security#Key",
"authenticationTag": "https://w3id.org/security#authenticationTag",
"canonicalizationAlgorithm": "https://w3id.org/security#canonicalizationAlgorithm",
"cipherAlgorithm": "https://w3id.org/security#cipherAlgorithm",
"cipherData": "https://w3id.org/security#cipherData",
"cipherKey": "https://w3id.org/security#cipherKey",
"created": {"@id": "http://purl.org/dc/terms/created", "@type": "http://www.w3.org/2001/XMLSchema#dateTime"},
"creator": "http://purl.org/dc/terms/createdcreator",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"creator": "http://purl.org/dc/terms/createdcreator",
"creator": {"@id": "http://purl.org/dc/terms/creator", "@type": "@id"},

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will fix this.

"digestAlgorithm": "https://w3id.org/security#digestAlgorithm",
"digestValue": "https://w3id.org/security#digestValue",
"domain": "https://w3id.org/security#domain",
"encryptionKey": "https://w3id.org/security#encryptionKey",
"expiration": {"@id": "https://w3id.org/security#expiration", "@type": "http://www.w3.org/2001/XMLSchema#dateTime"},
"expires": {"@id": "https://w3id.org/security#expiration", "@type": "http://www.w3.org/2001/XMLSchema#dateTime"},
"initializationVector": "https://w3id.org/security#initializationVector",
"iterationCount": "https://w3id.org/security#iterationCount",
"nonce": "https://w3id.org/security#nonce",
"normalizationAlgorithm": "https://w3id.org/security#normalizationAlgorithm",
"owner": "https://w3id.org/security#owner",
"password": "https://w3id.org/security#password",
"privateKey":"https://w3id.org/security#privateKey",
"privateKeyPem": "https://w3id.org/security#privateKeyPem",
"publicKey": "https://w3id.org/security#publicKey",
"publicKeyBase58": "https://w3id.org/security#publicKeyBase58",
"publicKeyPem": "https://w3id.org/security#publicKeyPem",
"publicKeyWif": "https://w3id.org/security#publicKeyWif",
"publicKeyService": "https://w3id.org/security#publicKeyService",
"revoked": {"@id": "https://w3id.org/security#revoked", "@type": "http://www.w3.org/2001/XMLSchema#dateTime"},
"salt": "https://w3id.org/security#salt",
"signature": "https://w3id.org/security#signature",
"signatureAlgorithm": "https://w3id.org/security#signingAlgorithm",
"signatureValue": "https://w3id.org/security#signatureValue",

"AesKeyWrappingKey2019": "https://w3id.org/security#AesKeyWrappingKey2019",
"DeleteKeyOperation": "https://w3id.org/security#DeleteKeyOperation",
"DeriveSecretOperation": "https://w3id.org/security#DeriveSecretOperation",
"EcdsaSecp256k1Signature2019": {
"@id": "https://w3id.org/security#EcdsaSecp256k1Signature2019",
"@context": {
"@version": 1.1,
"@protected": true,

"id": "@id",
"type": "@type",

"sec": "https://w3id.org/security#",
"xsd": "http://www.w3.org/2001/XMLSchema#",

"challenge": "sec:challenge",
"created": {"@id": "http://purl.org/dc/terms/created", "@type": "xsd:dateTime"},
"domain": "sec:domain",
"expires": {"@id": "sec:expiration", "@type": "xsd:dateTime"},
"jws": "sec:jws",
"nonce": "sec:nonce",
"proofPurpose": {
"@id": "sec:proofPurpose",
"@type": "@vocab",
"@context": {
"@version": 1.1,
"@protected": true,

"id": "@id",
"type": "@type",

"sec": "https://w3id.org/security#",

"assertionMethod": {"@id": "sec:assertionMethod", "@type": "@id", "@container": "@set"},
"authentication": {"@id": "sec:authenticationMethod", "@type": "@id", "@container": "@set"}
}
},
"proofValue": "sec:proofValue",
"verificationMethod": {"@id": "sec:verificationMethod", "@type": "@id"}
}
},
"EcdsaSecp256r1Signature2019": {
"@id": "https://w3id.org/security#EcdsaSecp256r1Signature2019",
"@context": {
"@version": 1.1,
"@protected": true,

"id": "@id",
"type": "@type",

"sec": "https://w3id.org/security#",
"xsd": "http://www.w3.org/2001/XMLSchema#",

"challenge": "sec:challenge",
"created": {"@id": "http://purl.org/dc/terms/created", "@type": "xsd:dateTime"},
"domain": "sec:domain",
"expires": {"@id": "sec:expiration", "@type": "xsd:dateTime"},
"jws": "sec:jws",
"nonce": "sec:nonce",
"proofPurpose": {
"@id": "sec:proofPurpose",
"@type": "@vocab",
"@context": {
"@version": 1.1,
"@protected": true,

"id": "@id",
"type": "@type",

"sec": "https://w3id.org/security#",

"assertionMethod": {"@id": "sec:assertionMethod", "@type": "@id", "@container": "@set"},
"authentication": {"@id": "sec:authenticationMethod", "@type": "@id", "@container": "@set"}
}
},
"proofValue": "sec:proofValue",
"verificationMethod": {"@id": "sec:verificationMethod", "@type": "@id"}
}
},
"EcdsaSecp256k1VerificationKey2019": "https://w3id.org/security#EcdsaSecp256k1VerificationKey2019",
"EcdsaSecp256r1VerificationKey2019": "https://w3id.org/security#EcdsaSecp256r1VerificationKey2019",
"Ed25519VerificationKey2018": "https://w3id.org/security#Ed25519VerificationKey2018",
"EquihashProof2018": "https://w3id.org/security#EquihashProof2018",
"ExportKeyOperation": "https://w3id.org/security#ExportKeyOperation",
"GenerateKeyOperation": "https://w3id.org/security#GenerateKeyOperation",
"KmsOperation": "https://w3id.org/security#KmsOperation",
"RevokeKeyOperation": "https://w3id.org/security#RevokeKeyOperation",
"RsaSignature2018": {
"@id": "https://w3id.org/security#RsaSignature2018",
"@context": {
"@version": 1.1,
"@protected": true,

"challenge": "sec:challenge",
"created": {"@id": "http://purl.org/dc/terms/created", "@type": "xsd:dateTime"},
"domain": "sec:domain",
"expires": {"@id": "sec:expiration", "@type": "xsd:dateTime"},
"jws": "sec:jws",
"nonce": "sec:nonce",
"proofPurpose": {
"@id": "sec:proofPurpose",
"@type": "@vocab",
"@context": {
"@version": 1.1,
"@protected": true,

"id": "@id",
"type": "@type",

"sec": "https://w3id.org/security#",

"assertionMethod": {"@id": "sec:assertionMethod", "@type": "@id", "@container": "@set"},
"authentication": {"@id": "sec:authenticationMethod", "@type": "@id", "@container": "@set"}
}
},
"proofValue": "sec:proofValue",
"verificationMethod": {"@id": "sec:verificationMethod", "@type": "@id"}
}
},
"RsaVerificationKey2018": "https://w3id.org/security#RsaVerificationKey2018",
"Sha256HmacKey2019": "https://w3id.org/security#Sha256HmacKey2019",
"SignOperation": "https://w3id.org/security#SignOperation",
"UnwrapKeyOperation": "https://w3id.org/security#UnwrapKeyOperation",
"VerifyOperation": "https://w3id.org/security#VerifyOperation",
"WrapKeyOperation": "https://w3id.org/security#WrapKeyOperation",
"X25519KeyAgreementKey2019": "https://w3id.org/security#X25519KeyAgreementKey2019",

"allowedAction": "https://w3id.org/security#allowedAction",
"assertionMethod": {"@id": "https://w3id.org/security#assertionMethod", "@type": "@id", "@container": "@set"},
"authentication": {"@id": "https://w3id.org/security#authenticationMethod", "@type": "@id", "@container": "@set"},
"capability": {"@id": "https://w3id.org/security#capability", "@type": "@id"},
"capabilityAction": "https://w3id.org/security#capabilityAction",
"capabilityChain": {"@id": "https://w3id.org/security#capabilityChain", "@type": "@id", "@container": "@list"},
"capabilityDelegation": {"@id": "https://w3id.org/security#capabilityDelegationMethod", "@type": "@id", "@container": "@set"},
"capabilityInvocation": {"@id": "https://w3id.org/security#capabilityInvocationMethod", "@type": "@id", "@container": "@set"},
"caveat": {"@id": "https://w3id.org/security#caveat", "@type": "@id", "@container": "@set"},
"challenge": "https://w3id.org/security#challenge",
"ciphertext": "https://w3id.org/security#ciphertext",
"controller": {"@id": "https://w3id.org/security#controller", "@type": "@id"},
"delegator": {"@id": "https://w3id.org/security#delegator", "@type": "@id"},
"equihashParameterK": {"@id": "https://w3id.org/security#equihashParameterK", "@type": "xsd:integer"},
"equihashParameterN": {"@id": "https://w3id.org/security#equihashParameterN", "@type": "xsd:integer"},
"invocationTarget": {"@id": "https://w3id.org/security#invocationTarget", "@type": "@id"},
"invoker": {"@id": "https://w3id.org/security#invoker", "@type": "@id"},
"jws": "https://w3id.org/security#jws",
"keyAgreement": {"@id": "https://w3id.org/security#keyAgreementMethod", "@type": "@id", "@container": "@set"},
"kmsModule": {"@id": "https://w3id.org/security#kmsModule"},
"parentCapability": {"@id": "https://w3id.org/security#parentCapability", "@type": "@id"},
"plaintext": "https://w3id.org/security#plaintext",
"proof": {"@id": "https://w3id.org/security#proof", "@type": "@id", "@container": "@graph"},
"proofPurpose": {"@id": "https://w3id.org/security#proofPurpose", "@type": "@vocab"},
"proofValue": "https://w3id.org/security#proofValue",
"referenceId": "https://w3id.org/security#referenceId",
"unwrappedKey": "https://w3id.org/security#unwrappedKey",
"verificationMethod": {"@id": "https://w3id.org/security#verificationMethod", "@type": "@id"},
"verifyData": "https://w3id.org/security#verifyData",
"wrappedKey": "https://w3id.org/security#wrappedKey"
}
]
}