Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-overflow-3] Correct scrollbar space description #11287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gitspeaks
Copy link

The terms "inner" and "outer" are not defined for border and padding edges in The CSS Box Model. These terms are unnecessary, undefined in this context, and their removal makes the description more clear.

@gitspeaks gitspeaks changed the title Clarify scrolling space description by simplifying edge terminology [css-overflow-3] Clarify scrolling space description by simplifying edge terminology Nov 27, 2024
@gitspeaks gitspeaks changed the title [css-overflow-3] Clarify scrolling space description by simplifying edge terminology [css-overflow-3] Clarify scrollar space description by simplifying edge terminology Nov 28, 2024
Copy link
Contributor

@Loirooriol Loirooriol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true that these terms are not defined, but your proposal seems to imply that the scrollbar is placed on the border area.

CSS Overflow could be clearer but it's basically separating the padding edge from CSS Box into 2 edges: the outer padding edge (on the inside) and the inner border edge (on the outside). The area between them is where the scrollbar is placed, i.e. the scrollbar gutter.

@Loirooriol Loirooriol added the css-overflow-3 Current Work label Nov 29, 2024
@gitspeaks
Copy link
Author

It's true that these terms are not defined, but your proposal seems to imply that the scrollbar is placed on the border area.

I'm not proposing anything. I just edited what is otherwise the only logical interpretation under the current definition of edges. If this results in an incorrect placement of the gutter, feel free to dismiss this pull request once proper definitions are in place.

CSS Overflow could be clearer

It’s not about clarity. The issue is that there’s simply no definition for "inner" or "outer" in the context of borders and padding.

but it's basically separating the padding edge from CSS Box into 2 edges: the outer padding edge (on the inside) and the inner border edge (on the outside). The area between them is where the scrollbar is placed, i.e. the scrollbar gutter.

This doesn’t make sense to me. The border area is defined as the space between the padding edge and the border edge. What you’re calling "inner border" is actually the padding edge. Under the current definition of edges as perimeters, there is no additional "area between edges" beyond what is already specified.

@Loirooriol
Copy link
Contributor

Under the current definition

I'm claiming that CSS Overflow is implicitly patching the CSS Box definition

@gitspeaks
Copy link
Author

I'm claiming that CSS Overflow is implicitly patching the CSS Box definition

This patch seems to introduce a conceptual bug.

@gitspeaks
Copy link
Author

See #11288

@gitspeaks gitspeaks changed the title [css-overflow-3] Clarify scrollar space description by simplifying edge terminology [css-overflow-3] Correct scrollbar space description Nov 29, 2024
@gitspeaks
Copy link
Author

I am submitting the pull request under the CC0 license.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css-overflow-3 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants