Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize PTZ capabilities/settings based on PTZ permission #245

Closed
beaufortfrancois opened this issue Aug 14, 2020 · 7 comments · Fixed by #260
Closed

Sanitize PTZ capabilities/settings based on PTZ permission #245

beaufortfrancois opened this issue Aug 14, 2020 · 7 comments · Fixed by #260
Labels

Comments

@beaufortfrancois
Copy link
Contributor

As raised by @youennf in #243 (comment), the spec should say clearly that PTZ capabilities are not available when PTZ permission is not granted. Same for PTZ settings.

@eehakkin Can you take care of this?

@youennf
Copy link
Contributor

youennf commented Aug 14, 2020

To be clear, it might be ok to allow web page to know that a selected camera has PTZ so that web page asks more permission to user. This is up to discussion but the spec should clearly specify it either way.

For PTZ settings, spec should clearly mandate sanitization.

@beaufortfrancois
Copy link
Contributor Author

For info, Chromium implementation sanitizes PTZ capabilities and settings based on PTZ permission.

@youennf
Copy link
Contributor

youennf commented Aug 14, 2020

The particular case of PTZ capabilities seems worth getting input from the WebRTC WG.

eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 18, 2020
eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 18, 2020
@eehakkin
Copy link
Contributor

So the corresponding pull request is #248.

eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 19, 2020
eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 19, 2020
eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 19, 2020
eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 20, 2020
eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 20, 2020
eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Aug 20, 2020
riju pushed a commit that referenced this issue Aug 21, 2020
riju added a commit that referenced this issue Aug 21, 2020
…apabilities

Clarify pan/tilt/zoom capabilities (#245)
eehakkin added a commit to eehakkin/intel-w3c-mediacapture-image that referenced this issue Sep 22, 2020
riju added a commit that referenced this issue Sep 24, 2020
@eehakkin
Copy link
Contributor

As raised by @youennf in #243 (comment), the spec should say clearly that PTZ capabilities are not available when PTZ permission is not granted. Same for PTZ settings.

The both changes have now been merged.

@beaufortfrancois
Copy link
Contributor Author

Thanks! I'll close it.
@youennf Feel free to re-open if there's something we've missed.

@jan-ivar
Copy link
Member

This issue has a resolution associated with it in the minutes so I think it should remain open until its PR has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants