Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better documentation of ended event #924

Open
eladalon1983 opened this issue Jan 11, 2023 · 0 comments
Open

Better documentation of ended event #924

eladalon1983 opened this issue Jan 11, 2023 · 0 comments

Comments

@eladalon1983
Copy link
Member

eladalon1983 commented Jan 11, 2023

MediaStreamTrack.ended reads:

The MediaStreamTrack object's source will no longer provide any data, either because the user revoked the permissions, or because the source device has been ejected, or because the remote peer permanently stopped sending data.

This fails to mention the caveat here:

When a MediaStreamTrack track ends for any reason other than the stop() method being invoked
...
4. Fire an event named ended at the object.

Possibly we could extend the desciption: "... Note that if the application itself stopped the track, by calling the stop() method, then this event will not be fired."

@jan-ivar jan-ivar added this to the Future Version milestone Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants