Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reference to MiniApp Manifest #21

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Add reference to MiniApp Manifest #21

merged 4 commits into from
Mar 24, 2022

Conversation

QingAn
Copy link
Contributor

@QingAn QingAn commented Feb 21, 2022 •
edited by pr-preview bot
Loading

@QingAn
Copy link
Contributor Author

QingAn commented Feb 24, 2022 •
edited
Loading

This PR is to solve the comment from w3ctag/design-reviews#523 (comment)

  1. The lifecycle document doesn't reference Manifest at all. It was our understanding that Miniapps would use the manifest file with the Miniapp extensions and that doesn't seem to be referenced in the document.

@QingAn
Update index.html
0b86298 
Add a note for clarification
@QingAn
Copy link
Contributor Author

QingAn commented Feb 24, 2022

@xfq @espinr I have made the update, adding a note for clarification. Please have a check.

espinr
espinr reviewed Mar 4, 2022
View reviewed changes
Copy link

@espinr espinr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very relevant, and I can do it later. If you want, we can include the reference to the definition of the pages member. I've exported the pages member definition in w3c/miniapp-manifest@00b25a7 . Then we simply need to add this markup:

<aside class="note" data-cite="MINIAPP-MANIFEST">
    ... the Manifest's [=pages=] member...

index.html Outdated Show resolved Hide resolved
espinr
espinr approved these changes Mar 9, 2022
View reviewed changes
Copy link

@espinr espinr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @QingAn !

@QingAn
Copy link
Contributor Author

QingAn commented Mar 24, 2022

Consensus to merge in MiniApp WG meeting 2022-03-24

@QingAn QingAn merged commit 1176483 into main Mar 24, 2022
@QingAn QingAn mentioned this pull request Mar 24, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espinr espinr espinr approved these changes

@xfq xfq xfq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QingAn @xfq @espinr