Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Q] What happens when "executionContexts" is present along with Location header? #56

Open
ashucg opened this issue Nov 24, 2018 · 6 comments

Comments

@ashucg
Copy link

ashucg commented Nov 24, 2018

My main question is what should happen when Clear-Site-Data: "executionContexts" and Location, both, headers are present?

I tried it on Firefox and it causes a reload loop so just wondering whether Location header is ought to be omitted if using executionContexts?

@annevk
Copy link
Member

annevk commented Nov 26, 2018

Given the proposed Fetch integration I suspect Firefox is technically correct. That doesn't seem like great design however.

cc @bakulf

@annevk
Copy link
Member

annevk commented Dec 6, 2018

A possible solution here could be to only honer this header on 2xx responses.

@mikewest what does Chrome do here?

@annevk
Copy link
Member

annevk commented Jan 10, 2019

Due to the lack of reply Firefox will only adhere to it on 2xx responses for now.

@julienw
Copy link

julienw commented Feb 20, 2019

@annevk we found this while looking at a solution to migrate the domain in a service-worker enabled website (namely: perf-html.io -> profiler.firefox.com). Normally we'd use a 301 for this, but this would break our service worker (a 301 response isn't a "ok" response so this breaks in code such as this one).

Using Clear-Site-Data is another possible solution but it's now completely ignored in Firefox for redirections. While it may make sense in the context of executionContexts I believe it would be useful to make it work for storage, this could even be a sensible use.

@annevk
Copy link
Member

annevk commented Feb 20, 2019

I'm not sure I understand the setup. As part of the redirect you want to clear the data on the old domain? I guess that makes sense.

@julienw
Copy link

julienw commented Feb 20, 2019

As part of the redirect you want to clear the data on the old domain? I guess that makes sense.

Yeah that's exactly this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants