Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatch a pointer down action has invalid parameters #1817

Closed
ChernyshevDS opened this issue Jun 10, 2024 · 3 comments
Closed

Dispatch a pointer down action has invalid parameters #1817

ChernyshevDS opened this issue Jun 10, 2024 · 3 comments

Comments

@ChernyshevDS
Copy link
Contributor

Dispatch a pointerDown action does not accept input source as a parameter. It seems that input source is mixed up with input state, because following items do not make sense because input source does not have expected properties:

  1. If the input state's pressed property contains button return success with data null.
  1. Let x be equal to input state's x property.
  1. Let y be equal to input state's y property.
  1. Add button to the set corresponding to input state's pressed property, and let buttons be the resulting value of that property.
@whimboo
Copy link
Contributor

whimboo commented Jun 27, 2024

@ChernyshevDS thanks for reporting the issue. Checking the table of action algorithms and how to dispatch those it is clear that the second argument indeed has to be the source. You can see this as well for the Dispatch a pointerUp action case.

Would you be interested to fix this bug in the specification? We would appreciate.

ChernyshevDS pushed a commit to ChernyshevDS/webdriver that referenced this issue Jun 27, 2024
…3c#1817)

Incorrect parameter name "input state" was replaced with "source"
@ChernyshevDS
Copy link
Contributor Author

@whimboo Sure, I've created a PR: #1820

whimboo pushed a commit that referenced this issue Jun 28, 2024
) (#1820)

Incorrect parameter name "input state" was replaced with "source"

Co-authored-by: daniilch <[email protected]>
github-actions bot added a commit that referenced this issue Jun 28, 2024
) (#1820)

SHA: 629163e
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@whimboo
Copy link
Contributor

whimboo commented Jun 28, 2024

Fixed by #1820.

@whimboo whimboo closed this as completed Jun 28, 2024
github-actions bot added a commit to ZRDKPoWeR/webdriver that referenced this issue Jun 30, 2024
…c#1817) (w3c#1820)

SHA: 629163e
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants