Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error and warning codes for extensions (manifest declaration and API usage) #633

Closed
solomonkinard opened this issue Jun 6, 2024 · 4 comments
Labels
needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time needs-triage: safari Safari needs to assess this issue for the first time

Comments

@solomonkinard
Copy link
Contributor

Adding error / warning codes for extensions would make it possible for extension developers to find their code into the distant future even if the message itself has changed.

This could be enabled for manifest declaration and API usage.

A con is that it could be a lot of work for maybe little benefit.

What are your ideas, and any pros and cons to share?

@github-actions github-actions bot added needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time needs-triage: safari Safari needs to assess this issue for the first time labels Jun 6, 2024
@solomonkinard
Copy link
Contributor Author

I'm not necessarily advocating for using the same error code across different browsers. But if someone wants to champion that, please share pros and cons.

@Rob--W
Copy link
Member

Rob--W commented Jun 6, 2024

I mainly see advantages if it is possible for browsers to share a common set of error codes. Otherwise it would be browser-specific and extension authors may as well just check the error message strings themselves.

@carlosjeurissen
Copy link
Contributor

Very much in favour of at least addressing some of the inconsistencies when it comes to error messages as even an error message of a missing property in a specific API call can differ across browsers. However in the given example an error / warning code would still need to be accompanied by some additional data like in this case the missing property.

@solomonkinard
Copy link
Contributor Author

Thanks. Those sound like reasonable ideas. I don't personally plan on championing this right now for cross-browsers. But anyone can run with this at any time if they're interested. In order to move forward, someone else would need to do at least the following:

  1. deciding what format to show in the UI
  2. document one or more codes in common
  3. put documentation in version control

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage: chrome Chrome needs to assess this issue for the first time needs-triage: firefox Firefox needs to assess this issue for the first time needs-triage: safari Safari needs to assess this issue for the first time
Projects
None yet
Development

No branches or pull requests

3 participants