Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No transfer steps defined for RTCEncodedAudioFrame and RTCEncodedVideoFrame #231

Open
luciaalonsomozo opened this issue Aug 30, 2024 · 3 comments

Comments

@luciaalonsomozo
Copy link

The spec uses StructuredSerializeWithTransfer in the writeEncodedData algorithm but it does not define the transfer steps which are part of the StructuredSerializeWithTransfer algorithm (step 5.5.4).

This leads to different behaviours by different implementations as seen in this WPT.

Another potential issue is that serialization is with StructuredSerializeWithTransfer but deserialization is with StructuredDeserialize. Shouldn't it be StructuredDeserializeWithTransfer?

@guidou
Copy link
Collaborator

guidou commented Sep 12, 2024

cc @youennf @alvestrand @jan-ivar

@jan-ivar
Copy link
Member

cc @docfaraday

@youennf
Copy link
Collaborator

youennf commented Sep 13, 2024

I think the intent of the spec is to transfer the [[data]] arrayBuffer and leave the other fields untouched.
That is why the spec uses StructuredSerializeWithTransfer(frame, « data »).
Agreed we need to clarify the spec, whatever we choose to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants