Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JSEP Modifications #164

Closed
wants to merge 5 commits into from
Closed

Remove JSEP Modifications #164

wants to merge 5 commits into from

Conversation

aboba
Copy link
Contributor

@aboba aboba commented Apr 26, 2023

Fixes #134

There is an existing process for submitting RFC 8829 errata, as well as for updating RFC 8829bis (now in the RFC Editor queue). Let's see if we can address these JSEP issues some other way. Justin Uberti will join us at the May 4 WEBRTC WG Editor's meeting to discuss alternatives.


Preview | Diff

There is an existing process for submitting RFC 8829 errata, as well as for updating RFC 8829bis (now in the RFC Editor queue).  Let's see if we can address these JSEP issues some other way.
@henbos
Copy link
Collaborator

henbos commented Apr 27, 2023

JSEP talks about "For each supported RTP header extension", so one might argue that a JSEP-compatible version of this PR that doesn't turn the API into a NO-OP might be to replaces the JSEP modifications with one new step at the end of setHeaderExtensionsToNegotiate: "Modify the underlying set of supported RTP header extensions to match [[HeaderExtensionsToNegotiate]]."

You might want to argue whether that is or is not OK but it seems better than a NO-OP until we have something in JSEP to do what we want.

@aboba
Copy link
Contributor Author

aboba commented Apr 27, 2023

@henbos RFC 8829bis assumes that "supported" RTP header extensions are always offered, and if offered, are answered. But with the RTP header extension API only the "mandatory to use" RTP header extensions are automatically offered/answered; a "supported" RTP header extension also needs to be in the [[HeaderExtensionsToNegotiate]]. So if we can still change RFC 8829bis, perhaps we can swap out the word "supported" for something better without having to refer to internal slots. If we can't modify RFC 8829bis, your suggestion might work.

@henbos
Copy link
Collaborator

henbos commented Apr 27, 2023

rtcweb-wg/jsep#1031

@henbos
Copy link
Collaborator

henbos commented Apr 27, 2023

rtcweb-wg/jsep#1032

@alvestrand
Copy link
Contributor

alvestrand commented May 16, 2023

In order to not derail our work that depends on the JSEP changes, I suggest that we update our JSEP reference to point to the -bis draft as part of this PR.
If we can't say "JSEP needs to change" in our document, we need to be able to point to the WIP document that makes the changes.

(The PR has a "JSEPbis" reference, but it does not resolve)

@dontcallmedom-bot
Copy link

@dontcallmedom-bot
Copy link

This issue was mentioned in WEBRTCWG-2023-05-16 (Page 24)

@aboba
Copy link
Contributor Author

aboba commented Jul 6, 2023

PTAL: rtcweb-wg/jsep#1033

@aboba aboba closed this by deleting the head repository Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should setOfferedHeaderExtensions be allowed to restart stopped extensions?
5 participants