Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need a control API for RTCP feedback mechanisms? #143

Open
alvestrand opened this issue Feb 28, 2023 · 3 comments
Open

Do we need a control API for RTCP feedback mechanisms? #143

alvestrand opened this issue Feb 28, 2023 · 3 comments

Comments

@alvestrand
Copy link
Collaborator

When hunting an unrelated problem, I came across the need to check whether or not certain RTCP feedback mechanisms (nack, rrtr, transport-cc) were turned on.
It turned out that in order to do this, I had to do SDP inspection or C++ APIs; I would have to do the same thing to affect them.

Do we have an use case where it makes sense to expose an API to turn these mechanisms on and off?

(For extra credit: turn on and off feedback mechanisms that are transport-wide rather than codec-dependent)

@bdrtc
Copy link

bdrtc commented Feb 28, 2023

As webrtc app developer, it's easy to see whether or not certain RTCP were turned on/off by analize default sdp.
But when the user want to turn on or off a certain rtcp feature, it is inconvenient (sdp munging),
so to add a control api is more convenient, then, what level api will you want?
maybe we should consider

1)media type level
user may want disable audio tcc/others but open for video.
2)media direction
user may want use remb rtcp in media send direction but use tcc in media receive direction.

@aboba
Copy link
Contributor

aboba commented Apr 26, 2023

In ORTC, we had rtcpFeedback included in RTCRtpCodecCapability (for discovery) as well as in RTCRtpCodecParameters (for configuration).

@dontcallmedom-bot
Copy link

This issue was mentioned in WEBRTCWG-2023-05-16 (Page 25)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants