-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make RtpTransportProcessor transferable #33
Comments
And we need to make sure we can't transfer the RtpTransport if you've already attached an event handler when on the main thread. |
With the current proposal, you can get the RTCRtpTransport from RTCRtpSender/RTCRtpReceiver. |
This issue was mentioned in WebRTC Interim, May 21st – 21 May 2024 (RtpTransport (Peter Thatcher)) |
Should there be an RTCRtpTransportProcessor embedded within the RTCRtpTransport that is the object that can be moved to (or instantiated in) a different context than where the PeerConnection lives? |
Some of the functionality added in RTPTransport, like custom pacing, makes much more sense in a worker than in a window environment. |
Some kind of transferable |
Right, we could move the current attributes, event handlers and
|
I would tend to go with something similar to WebRTC encoded transform.
|
Would we want to support clearing/assigning a new For argument's sake, an alternative would be making processor itself transferrable, provided as a direct attribute on
This is the same debate as that taking place in #36 for RtpSendStream/RtpReceiveStream. |
@tonyherre This looks good. |
@youennf what's the purpose of the If we took the approach of triggering an event in the worker instead of general Transferability, wouldn't it work as well to just have a method directly on RTCRtpTransport:
thus saving us an interface and a lot of theoretical corner cases around Handler lifecycles. |
Btw, I've tried out the event-based transfer (using a Seems to work quite nicely. I still mildly prefer Transferability but would be fine with this. Discovered that a big benefit of using a |
Once it's transferred, PeerConnection.RtpTransport no longer allows you to attach an event handler, because only the RtpTransport that was transferred can attach an event handler.
The text was updated successfully, but these errors were encountered: