Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats example uses confusing variable names #768

Open
henbos opened this issue Aug 10, 2023 · 0 comments
Open

Stats example uses confusing variable names #768

henbos opened this issue Aug 10, 2023 · 0 comments

Comments

@henbos
Copy link
Collaborator

henbos commented Aug 10, 2023

https://w3c.github.io/webrtc-stats/#example-of-a-stats-application uses variable names that refer to both RTCStats (report) and RTCStatsReport (currentReport) as reports.

Clearly one is a report and one is a stats object. The former is clearly a report and the latter, well up for debate if this should be called stat or stats or statsObject. I don't really care as long as we don't call it a report.

Normally I wouldn't care that this example is using silly variable names, but apparently we have duplicated this confusion to both samples and CLs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant