-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect support for waitUntilAvailable=true? #613
Comments
You should be able to feature detect it like this: let supported = false;
wt.createUnidirectionalStream({get waitUntilAvailable() { supported = true; }});
console.log(supported); // true or false This existing pattern relies on step 5 in createUnidirectionalStream. Please LMK if this is insufficient. |
Please reopen if this is still an issue. |
I'm sorry for the late reply. For the last few weeks, I have been traveling with limited internet access. |
Another question: I have the impression that Firefox currently behaves as if waitUntilAvailable is set to true. Is this observation correct? I am wondering how to deal with it. Either write an exception in the test, or a patch for the browser.... |
I think the current Chrome behavior is |
Well, in my unit tests for stream flow control: https://github.com/fails-components/webtransport/blob/master/test/stream-limits.spec.js. Chromium behaves as |
Good point. I've filed bug 1917831 on Firefox to fix this. Thanks! |
Also, Chrome has close to 150 streams available, and Firefox has close to 100 streams available. (I think I have read that there was some consensus to choose a similar value.) |
The server dictates the number of streams you can create, so if Chrome and Firefox differ that's a bug somewhere. Maybe you're thinking of anticipatedConcurrentIncomingUnidirectionalStreams which says: "The user agent MUST initially allow at least 100 incoming unidirectional streams from the server.", but that's in the other direction. |
Deleted. |
Ok, I have check it, I just forgot, that I used server side different limits for the two waituntilavailable values. |
I currently have the following issues:
I am running automated tests to get new streams.
If waitUntilAvailable=true is supported (there is no support currently, right?), the tests must run differently.
So far, the test for waitUntilAvailable=true has failed as there is no support (at least in Chrome). How should an application detect support for waitUntilAvailabl? It may be crucial, as the behavior for allocating streams may differ.
(Of course, this may be an unimportant detail, but it is a thought that came to me while writing tests. (However, until now, I manually select or deselect the tests depending on the browser engine.)
The text was updated successfully, but these errors were encountered: