Skip to content

Commit c5afe50

Browse files
committed
Make VTTRegion lines be a long.
Because WebIDL doesn't include an unsigned int, the VTTRegion interface specifically calls out that negative numbers should cause an IndexSizeError, and browser implementations are in the unsigned int, switch over to using a regular long value. Using a long gives us the correct range and with the definition that specifies throwing means that negative values are not allowed. This was discussed in the [20 June, 2019 TTWG call](https://www.w3.org/2019/06/20-tt-minutes.html#x02) Fixes #457.
1 parent 5ddbe7b commit c5afe50

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

index.bs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5926,7 +5926,7 @@ enum ScrollSetting { "" /* none */, "up" };
59265926
interface VTTRegion {
59275927
attribute DOMString id;
59285928
attribute double width;
5929-
attribute unsigned long lines;
5929+
attribute long lines;
59305930
attribute double regionAnchorX;
59315931
attribute double regionAnchorY;
59325932
attribute double viewportAnchorX;

index.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1447,7 +1447,7 @@
14471447
<div class="head">
14481448
<p data-fill-with="logo"><a class="logo" href="https://www.w3.org/"> <img alt="W3C" height="48" src="https://www.w3.org/StyleSheets/TR/2016/logos/W3C" width="72"> </a> </p>
14491449
<h1 class="p-name no-ref" id="title">WebVTT: The Web Video Text Tracks Format</h1>
1450-
<h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Draft Community Group Report, <time class="dt-updated" datetime="2018-03-30">30 March 2018</time></span></h2>
1450+
<h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="content">Draft Community Group Report, <time class="dt-updated" datetime="2019-06-24">24 June 2019</time></span></h2>
14511451
<div data-fill-with="spec-metadata">
14521452
<dl>
14531453
<dt>This version:
@@ -1472,7 +1472,7 @@ <h2 class="no-num no-toc no-ref heading settled" id="subtitle"><span class="cont
14721472
</div>
14731473
<div data-fill-with="warning"></div>
14741474
<p class="copyright" data-fill-with="copyright"><a href="http://www.w3.org/Consortium/Legal/ipr-notice#Copyright">Copyright</a> ©
1475-
2011-2018
1475+
2011-2019
14761476
the Contributors to the WebVTT: The Web Video Text Tracks Format Specification, published by the <a href="http://www.w3.org/community/texttracks/">Web Media Text Tracks Community Group</a> under the <a href="https://www.w3.org/community/about/agreements/cla/">W3C Community Contributor License Agreement (CLA)</a>.
14771477
A human-readable <a href="http://www.w3.org/community/about/agreements/cla-deed/">summary</a> is available.</p>
14781478
<hr title="Separator for header">
@@ -5703,7 +5703,7 @@ <h3 class="heading settled algorithm" data-algorithm="The VTTRegion interface" d
57035703
<span class="kt">interface</span> <dfn class="nv dfn-paneled idl-code" data-dfn-type="interface" data-export="" id="vttregion"><code>VTTRegion</code></dfn> {
57045704
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-DOMString"><span class="kt">DOMString</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="DOMString" href="#dom-vttregion-id" id="ref-for-dom-vttregion-id-1">id</a>;
57055705
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-width" id="ref-for-dom-vttregion-width-1">width</a>;
5706-
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-unsigned-long"><span class="kt">unsigned</span> <span class="kt">long</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="unsigned long" href="#dom-vttregion-lines" id="ref-for-dom-vttregion-lines-1">lines</a>;
5706+
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-long"><span class="kt">long</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="long" href="#dom-vttregion-lines" id="ref-for-dom-vttregion-lines-1">lines</a>;
57075707
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-regionanchorx" id="ref-for-dom-vttregion-regionanchorx-1">regionAnchorX</a>;
57085708
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-regionanchory" id="ref-for-dom-vttregion-regionanchory-1">regionAnchorY</a>;
57095709
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-viewportanchorx" id="ref-for-dom-vttregion-viewportanchorx-1">viewportAnchorX</a>;
@@ -6451,7 +6451,7 @@ <h3 class="no-num no-ref heading settled" id="index-defined-elsewhere"><span cla
64516451
<li><a href="https://heycam.github.io/webidl/#indexsizeerror">IndexSizeError</a>
64526452
<li><a href="https://heycam.github.io/webidl/#idl-boolean">boolean</a>
64536453
<li><a href="https://heycam.github.io/webidl/#idl-double">double</a>
6454-
<li><a href="https://heycam.github.io/webidl/#idl-unsigned-long">unsigned long</a>
6454+
<li><a href="https://heycam.github.io/webidl/#idl-long">long</a>
64556455
</ul>
64566456
</ul>
64576457
<h2 class="no-num no-ref heading settled" id="references"><span class="content">References</span><a class="self-link" href="#references"></a></h2>
@@ -6564,7 +6564,7 @@ <h2 class="no-num no-ref heading settled" id="idl-index"><span class="content">I
65646564
<span class="kt">interface</span> <a class="nv" href="#vttregion"><code>VTTRegion</code></a> {
65656565
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-DOMString"><span class="kt">DOMString</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="DOMString" href="#dom-vttregion-id">id</a>;
65666566
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-width">width</a>;
6567-
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-unsigned-long"><span class="kt">unsigned</span> <span class="kt">long</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="unsigned long" href="#dom-vttregion-lines">lines</a>;
6567+
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-long"><span class="kt">long</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="long" href="#dom-vttregion-lines">lines</a>;
65686568
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-regionanchorx">regionAnchorX</a>;
65696569
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-regionanchory">regionAnchorY</a>;
65706570
<span class="kt">attribute</span> <a class="n idl-code" data-link-type="interface" href="https://heycam.github.io/webidl/#idl-double"><span class="kt">double</span></a> <a class="nv idl-code" data-link-type="attribute" data-type="double" href="#dom-vttregion-viewportanchorx">viewportAnchorX</a>;

0 commit comments

Comments
 (0)